-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] Support Octavia/Amphora Prometheus endpoint creation using annotations #2633
base: master
Are you sure you want to change the base?
[occm] Support Octavia/Amphora Prometheus endpoint creation using annotations #2633
Conversation
Hi @Lucasgranet. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ea89e68
to
1219946
Compare
fd375fb
to
569454a
Compare
/ok-to-test |
569454a
to
feba13d
Compare
feba13d
to
7fdbbc8
Compare
c01780a
to
f88e206
Compare
f88e206
to
5e72afc
Compare
/retest |
5e72afc
to
c7f67d3
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c7f67d3
to
1f4b6a9
Compare
1f4b6a9
to
19bf4ef
Compare
281075f
to
577edd4
Compare
577edd4
to
5ed72af
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Adds the ability to add a Prometheus listener on the Octavia LoadBalancer in order to fetch it with any Prometheus scrapper to get metrics from the LoadBalancer.
This PR brings 4 new annotations:
Why you should have to use
loadbalancer.openstack.org/metrics-allow-cidrs
It's strongly recommended to apply an allowed cidrs on the listener. If a Floating IP is attached to the Octavia, the metric endpoint will be exposed publicly. Apply a restriction to the K8S's subnet is recommended.
More detail on the Prometheus listener:
https://docs.openstack.org/octavia/latest/user/guides/monitoring.html#monitoring-with-prometheus
Which issue this PR fixes(if applicable):
fixes #2465
Special notes for reviewers:
A new E2E test has been added.
Release note: