build: add native-tls integration #87
Conversation
davehorner
changed the title
davehorner
force-pushed
the
native-tls
branch
from
835df4d to
de13f0f
Compare
davehorner
changed the title
eventsource-client/Cargo.toml
Outdated
|
|
||
| [[example]] | ||
| name = "tail" | ||
| required-features = ["rustls"] | ||
| required-features = ["native-tls"] |
There was a problem hiding this comment.
theres no way to default windows to this; you might what this line removed. lmk
davehorner
force-pushed
the
native-tls
branch
2 times, most recently
from
d1bcc86 to
9b6c18f
Compare
davehorner
force-pushed
the
native-tls
branch
from
9b6c18f to
c06c66d
Compare
| [[example]] | ||
| name = "tail" | ||
| required-features = ["rustls"] | ||
| native-tls = ["hyper-tls"] |
There was a problem hiding this comment.
removal of the required feature another way to go.
There was a problem hiding this comment.
when I try to run the contract-tests;
warning: [email protected]+zstd.1.5.6: cl : Command line warning D9002 : ignoring unknown option '-fvisibility=hidden'
warning: [email protected]+zstd.1.5.6: cl : Command line warning D9002 : ignoring unknown option '-fvisibility=hidden'
error: failed to run custom build command for zstd-sys v2.0.13+zstd.1.5.6
zstd is passing bad parameters to windows cl. windows is awesome.
|
Thank you for your contribution. I have filed this internally as SDK-1111 and will try to get SDK engineer to discuss and review this. |
|
Cool, what I have isn't the complete solution. I was having some issue with running samples or something. I remember that subsequent builds were a problem...default features and what not. the work of this is trying to understand the best way to configure the features so that we don't cause issues for others and enable this feature selection for people who need/prefer it. |
I'm having trouble on windows with ring. this works if you specify
briansmith/ring#2416