Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› fix: the agent setting -edit_agent not work #4609

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

mushan0x0
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

close #4562

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 5, 2024
Copy link

vercel bot commented Nov 5, 2024

@mushan0x0 is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the ๐Ÿ› Bug Something isn't working | ็ผบ้™ท label Nov 5, 2024
@lobehubbot
Copy link
Member

๐Ÿ‘ @mushan0x0

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 91.34%. Comparing base (963f788) to head (4e763c1).
Report is 73 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4609    +/-   ##
========================================
  Coverage   91.34%   91.34%            
========================================
  Files         728      728            
  Lines       68362    68362            
  Branches     3105     3303   +198     
========================================
  Hits        62448    62448            
  Misses       5914     5914            
Flag Coverage ฮ”
app 91.34% <รธ> (รธ)
server 97.57% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SAnBlog
Copy link

SAnBlog commented Nov 6, 2024

ไฝ•ๆ—ถๅˆๅนถPRๅ‘ข?

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


When will the PR be merged?

@arvinxx
Copy link
Contributor

arvinxx commented Mar 8, 2025

ๆˆ‘ๆ„Ÿ่ง‰ๅบ”่ฏฅๆ˜ฏ้š่—้‚ฃไธช็‚นๅ‡ปๅ…ฅๅฃ่€Œไธๆ˜ฏ็ฆ็”จ็ผ–่พ‘ๅง๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


I think it should be to hide the click portal instead of disabling editing?

@mushan0x0
Copy link
Contributor Author

ๆˆ‘ๆ„Ÿ่ง‰ๅบ”่ฏฅๆ˜ฏ้š่—้‚ฃไธช็‚นๅ‡ปๅ…ฅๅฃ่€Œไธๆ˜ฏ็ฆ็”จ็ผ–่พ‘ๅง๏ผŸ

ไธ่ƒฝ็ผ–่พ‘๏ผŒไฝ†ๆ˜ฏๆœ‰ๆŸฅ็œ‹้œ€ๆฑ‚็š„

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Mar 11, 2025 4:49am

@arvinxx arvinxx merged commit 7af0ec6 into lobehub:main Mar 12, 2025
13 of 15 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @mushan0x0 โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
### [Version&nbsp;1.70.10](v1.70.9...v1.70.10)
<sup>Released on **2025-03-12**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: The agent setting `-edit_agent` not work.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: The agent setting `-edit_agent` not work, closes [#4609](#4609) ([7af0ec6](7af0ec6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.70.10 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

@mushan0x0 mushan0x0 deleted the fix/edit_agent branch March 12, 2025 18:35
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Mar 13, 2025
### [Version&nbsp;1.111.1](v1.111.0...v1.111.1)
<sup>Released on **2025-03-13**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix crawl result for short content, fix theme flicking, Link jump in mobile terminal data statistics, refactor the theme implement, the agent setting `-edit_agent` not work.

#### ๐Ÿ’„ Styles

- **spelling**: Correct "broswer" to "browser" across codebase.
- **misc**: Support OpenRouter custom BaseURL.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix crawl result for short content, closes [lobehub#6903](https://github.com/bentwnghk/lobe-chat/issues/6903) [lobehub#6904](https://github.com/bentwnghk/lobe-chat/issues/6904) ([d8fda65](d8fda65))
* **misc**: Fix theme flicking, closes [lobehub#6926](https://github.com/bentwnghk/lobe-chat/issues/6926) ([103c3e3](103c3e3))
* **misc**: Link jump in mobile terminal data statistics, closes [lobehub#6893](https://github.com/bentwnghk/lobe-chat/issues/6893) ([505d24d](505d24d))
* **misc**: Refactor the theme implement, closes [lobehub#6844](https://github.com/bentwnghk/lobe-chat/issues/6844) ([e5c2161](e5c2161))
* **misc**: The agent setting `-edit_agent` not work, closes [lobehub#4609](https://github.com/bentwnghk/lobe-chat/issues/4609) ([7af0ec6](7af0ec6))

#### Styles

* **spelling**: Correct "broswer" to "browser" across codebase, closes [lobehub#6876](https://github.com/bentwnghk/lobe-chat/issues/6876) ([8d677a2](8d677a2))
* **misc**: Support OpenRouter custom BaseURL ([a8089ed](a8089ed))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Mar 13, 2025
## [Version&nbsp;1.18.0](v1.17.1...v1.18.0)
<sup>Released on **2025-03-13**</sup>

#### โœจ Features

- **misc**: Support no-fc models like deepseek r1 with online search.

#### ๐Ÿ› Bug Fixes

- **misc**: Fix anthropic max tokens, fix context cache control and model builtin search switch, fix crawl result for short content, fix theme flicking, Link jump in mobile terminal data statistics, refactor the theme implement, the agent setting `-edit_agent` not work, update cvpr cvf url rules.

#### ๐Ÿ’„ Styles

- **chat**: Auto send message from URL.
- **spelling**: Correct "broswer" to "browser" across codebase.
- **misc**: Support openrouter claude 3.7 sonnet reasoning, Support OpenRouter custom BaseURL.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Support no-fc models like deepseek r1 with online search, closes [lobehub#6842](https://github.com/jaworldwideorg/OneJA-Bot/issues/6842) ([f284c25](f284c25))

#### What's fixed

* **misc**: Fix anthropic max tokens, closes [lobehub#6859](https://github.com/jaworldwideorg/OneJA-Bot/issues/6859) ([35fbc6c](35fbc6c))
* **misc**: Fix context cache control and model builtin search switch, closes [lobehub#6831](https://github.com/jaworldwideorg/OneJA-Bot/issues/6831) ([5c6b8ea](5c6b8ea))
* **misc**: Fix crawl result for short content, closes [lobehub#6903](https://github.com/jaworldwideorg/OneJA-Bot/issues/6903) [lobehub#6904](https://github.com/jaworldwideorg/OneJA-Bot/issues/6904) ([d8fda65](d8fda65))
* **misc**: Fix theme flicking, closes [lobehub#6926](https://github.com/jaworldwideorg/OneJA-Bot/issues/6926) ([103c3e3](103c3e3))
* **misc**: Link jump in mobile terminal data statistics, closes [lobehub#6893](https://github.com/jaworldwideorg/OneJA-Bot/issues/6893) ([505d24d](505d24d))
* **misc**: Refactor the theme implement, closes [lobehub#6844](https://github.com/jaworldwideorg/OneJA-Bot/issues/6844) ([e5c2161](e5c2161))
* **misc**: The agent setting `-edit_agent` not work, closes [lobehub#4609](https://github.com/jaworldwideorg/OneJA-Bot/issues/4609) ([7af0ec6](7af0ec6))
* **misc**: Update cvpr cvf url rules, closes [lobehub#6860](https://github.com/jaworldwideorg/OneJA-Bot/issues/6860) ([c299067](c299067))

#### Styles

* **chat**: Auto send message from URL, closes [lobehub#6497](https://github.com/jaworldwideorg/OneJA-Bot/issues/6497) ([30b2639](30b2639))
* **spelling**: Correct "broswer" to "browser" across codebase, closes [lobehub#6876](https://github.com/jaworldwideorg/OneJA-Bot/issues/6876) ([8d677a2](8d677a2))
* **misc**: Support openrouter claude 3.7 sonnet reasoning, closes [lobehub#6806](https://github.com/jaworldwideorg/OneJA-Bot/issues/6806) ([f1ffc2c](f1ffc2c))
* **misc**: Support OpenRouter custom BaseURL ([a8089ed](a8089ed))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ› Bug Something isn't working | ็ผบ้™ท released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ๅŠŸ่ƒฝ้€‰ๆ‹ฉๅ˜้‡ไธๅฎŒๅ…จ็”Ÿๆ•ˆ
4 participants