MCOL-5852: GROUP_CONCAT memory accounting and disk based version #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a boolean flag and a couple of `if`s
mariadb-AlexeyAntipovsky
force-pushed
the
fix/MCOL-5852_part2
branch
from
cfb6748 to
467bf27
Compare
mariadb-AlexeyAntipovsky
requested review from
drrtuy and
mariadb-LeonidFedorov
|
I'll add some tests a bit later |
mariadb-LeonidFedorov
changed the title
mariadb-AlexeyAntipovsky
force-pushed
the
fix/MCOL-5852_part2
branch
from
6f495c5 to
d328a94
Compare
drrtuy
reviewed
Mar 21, 2025
| /* buf.fCurOutPtr points to the data to send; ByteStream guarantees that there | ||
| are at least 12 bytes before that for the magic & length fields */ | ||
| realBuf = (uint32_t*)msg.buf(); | ||
| realBuf -= 3; | ||
| realBuf[0] = magic; | ||
| realBuf[1] = msglen; | ||
| realBuf[2] = longStrings.size(); |
There was a problem hiding this comment.
I suppose you can remove this.
drrtuy
reviewed
Mar 21, 2025
| bs >> fTimeZone; | ||
| } | ||
|
|
||
| class OrderByRow |
There was a problem hiding this comment.
Name overlap with the class that is used by ORDER BY, so you should name it differently IMHO.
After this patch we can move both this sorting structs together with idborderby* into a specialized dir for a healty housekeeping.
drrtuy
reviewed
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.