Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption can get stuck #29534

Closed
richvdh opened this issue Mar 18, 2025 · 1 comment · Fixed by matrix-org/matrix-js-sdk#4761
Closed

Encryption can get stuck #29534

richvdh opened this issue Mar 18, 2025 · 1 comment · Fixed by matrix-org/matrix-js-sdk#4761
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Mar 18, 2025

Steps to reproduce

I was unable to reproduce this myself; I think it might be specific to MacOS, but from the logs, it goes something like this:

  1. Whilst a /keys/query request is in flight, lose internet connectivity
  2. Come back on line later, (at a different IP address, maybe?)
  3. Try to send a message in an encrypted room

Outcome

What did you expect?

The message is encrypted and sent

What happened instead?

It gets stuck in the "Encrypting" phase

Operating system

macOS

Browser information

Firefox 136.0

URL for webapp

app.element.io

Application version

1.11.95

Homeserver

matrix.org

Will you send logs?

Yes
@dosubot dosubot bot added A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 18, 2025
@richvdh
Copy link
Member Author

richvdh commented Mar 18, 2025

I think what happened here is that the /keys/query request was sent, and while we were waiting for the response, the network dropped, meaning the response got lost. Apparently there is no timeout or keepalive on the request, so an hour later, the OutgoingRequestProcessor was still waiting.

@richvdh richvdh mentioned this issue Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rust crypto: set a timeout on outgoing HTTP requests matrix-org/matrix-js-sdk
1 participant
@richvdh