Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust crypto: set a timeout on outgoing HTTP requests #4761

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 18, 2025

In an attempt to guard against the request loop getting stuck, put a timeout on outgoing HTTP requests.

Fixes: element-hq/element-web#29534

@richvdh richvdh added the T-Feature Request to add a new feature which does not exist right now label Mar 18, 2025
@richvdh richvdh marked this pull request as ready for review March 18, 2025 22:32
@richvdh richvdh requested a review from a team as a code owner March 18, 2025 22:32
@richvdh richvdh requested review from andybalaam and uhoreg March 18, 2025 22:32
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@richvdh richvdh added T-Enhancement and removed T-Feature Request to add a new feature which does not exist right now labels Mar 19, 2025
@richvdh richvdh enabled auto-merge March 19, 2025 16:37
@richvdh richvdh added this pull request to the merge queue Mar 19, 2025
Merged via the queue into develop with commit e2bdb2f Mar 19, 2025
42 of 44 checks passed
@richvdh richvdh deleted the rav/element-r/timeout_http_requests branch March 19, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encryption can get stuck
2 participants