Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatrixRTC: Rename MembershipConfig parameters #4714

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

MatrixRTC: Rename MembershipConfig parameters #4714

wants to merge 2 commits into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Feb 17, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5 toger5 marked this pull request as ready for review February 19, 2025 18:05
@toger5 toger5 requested a review from a team as a code owner February 19, 2025 18:05
@toger5 toger5 requested a review from AndrewFerr February 19, 2025 18:05
@toger5
Copy link
Contributor Author

toger5 commented Feb 19, 2025

Not sure what the merge order should be here in relation to: #4726 and #4713

@toger5 toger5 requested a review from hughns February 19, 2025 18:07
@hughns hughns changed the title Rename MembershipConfig parameters MatrixRTC: Rename MembershipConfig parameters Feb 21, 2025
@hughns hughns marked this pull request as draft February 28, 2025 14:23
@toger5
Copy link
Contributor Author

toger5 commented Feb 28, 2025

Do we want to make this backwards compatible and introduce a couple of deprecated old properties?
I argue: yes we want to keep the old names for backwards compatibility as deprecated options.

@toger5 toger5 mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from matrix-org/element-call-reviewers

@hughns hughns Awaiting requested review from hughns

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toger5