-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(timeline): add functions for sending messages in threads #4819
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Johannes Marbach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4819 +/- ##
==========================================
- Coverage 86.44% 86.42% -0.03%
==========================================
Files 297 297
Lines 34527 34548 +21
==========================================
+ Hits 29848 29859 +11
- Misses 4679 4689 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this should provide the ability to start a new thread.
send_reply
is geared towards clients that don't render threads themselves. It sends a reply and optionally forwards it onto any existing thread.This PR adds
send_thread_reply
for clients that do render threads themselves. This sends a message onto a thread, regardless of whether a thread existed before, and includes the fallback for non-threaded clients only if the message is not itself a reply on the thread.