Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timeline): add functions for sending messages in threads #4819

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Mar 19, 2025

send_reply is geared towards clients that don't render threads themselves. It sends a reply and optionally forwards it onto any existing thread.

This PR adds send_thread_reply for clients that do render threads themselves. This sends a message onto a thread, regardless of whether a thread existed before, and includes the fallback for non-threaded clients only if the message is not itself a reply on the thread.

  • Public API changes documented in changelogs (optional)

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 86.42%. Comparing base (a539518) to head (4883789).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/mod.rs 39.28% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
- Coverage   86.44%   86.42%   -0.03%     
==========================================
  Files         297      297              
  Lines       34527    34548      +21     
==========================================
+ Hits        29848    29859      +11     
- Misses       4679     4689      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Johennes Johennes marked this pull request as ready for review March 19, 2025 19:21
@Johennes Johennes requested a review from a team as a code owner March 19, 2025 19:22
@Johennes Johennes requested review from Hywan and removed request for a team March 19, 2025 19:22
@bnjbvr bnjbvr requested review from bnjbvr and removed request for Hywan March 20, 2025 09:44
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should provide the ability to start a new thread.

@Johennes Johennes requested a review from bnjbvr March 20, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants