Refresh the BMH v1beta1 design based on recent developments #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BMO has changed the default ChecksumType to auto without waiting for v1beta1, so now remove the explicit MD5 type instead. - Remove support for VDI and VMDK disk formats. They were disabled in the Ironic image validation fixes, and nobody has complained so far. These formats have never been tested by the Ironic or Metal3 communities. - Introduce an explicit InspectionMode similar to AutomatedCleaningMode. It will replace setting inspect.metal3.io to "disabled" with a proper API and pave the way to eventually add a Redfish-based option. - Replace UserData, MetaData and NetworkData with UserDataName, MetaDataName and NetworkDataName. It has been discovered that allowing secrets from a different namespace poses a security issue, so the Namespace field is not functional any more. Signed-off-by: Dmitry Tantsur <[email protected]>
metal3-io-bot
added
the
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BMO has changed the default ChecksumType to auto without waiting for
v1beta1, so now remove the explicit MD5 type instead.
Remove support for VDI and VMDK disk formats. They were disabled in
the Ironic image validation fixes, and nobody has complained so far.
These formats have never been tested by the Ironic or Metal3
communities.
Introduce an explicit InspectionMode similar to AutomatedCleaningMode.
It will replace setting inspect.metal3.io to "disabled" with a proper
API and pave the way to eventually add a Redfish-based option.
Replace UserData, MetaData and NetworkData with UserDataName,
MetaDataName and NetworkDataName. It has been discovered that allowing
secrets from a different namespace poses a security issue, so the
Namespace field is not functional any more.
Signed-off-by: Dmitry Tantsur [email protected]