Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Parliament (Independent Publisher) #3783

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

krautrocker
Copy link
Contributor


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

- paconn validated, no errors.
@krautrocker krautrocker requested a review from a team as a code owner February 22, 2025 18:10
@krautrocker
Copy link
Contributor Author

*Test UI results and proof-of-life in a flow.

Test UI:

GetPlenarProtokollTextById:

Screenshot 2025-02-22 114028

GetPlenarProtokollTextList:

Screenshot 2025-02-22 114042

GetAktivitaetList:

image

Proof-of-life in a flow:

Screenshot 2025-02-22 114929

Screenshot 2025-02-22 114948

Screenshot 2025-02-22 114959

@troystaylor
Copy link
Contributor

Hi Dan,
Connector looks good except for two things:

  1. Security doesn't need to be set at both root and action level, with root level being enough if all endpoints require it.
  2. Definitions are missing titles at the property/parameter level.

@krautrocker
Copy link
Contributor Author

Thanks, updated!

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krautrocker,

Please change all the German strings to English before we proceed for the review. However, please note that your connector will be translated to different languages once it is certified and eligible for the translation.

@krautrocker
Copy link
Contributor Author

Ah, I see! Will the terms be auto translated or translated by a human? Curious, as I'm a German speaker. Pretty cool, regardless.

Which strings need to be changed? Action names (Ex: Vorgangspositionen), summary prefixes (Ex: Vorgänge - ...), everywhere except the actual field names, I assume?

@vmanoharas
Copy link
Contributor

Ah, I see! Will the terms be auto translated or translated by a human? Curious, as I'm a German speaker. Pretty cool, regardless.

Which strings need to be changed? Action names (Ex: Vorgangspositionen), summary prefixes (Ex: Vorgänge - ...), everywhere except the actual field names, I assume?

Yes @krautrocker, the strings will be translated by our internal Localization team. Yes except actions and triggers, please change to English.

@krautrocker
Copy link
Contributor Author

@vmanoharas Beautiful, thank you. I did make an update yesterday that removed strings from the readme and the short strings that were at the start of action names to make them only English. I'll change the operation IDs to reflect the English equivalents as well. Lastly, I'll change the title "Deutscher Bundestag" to "German Bundestag."

Do let me know if I need to change anything else.

@vmanoharas
Copy link
Contributor

Hi @krautrocker,

Please refer the below link the title and the description must be in English.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission#give-your-connector-a-title

@krautrocker
Copy link
Contributor Author

2. Definitions are missing titles at the property/parameter level.

@troystaylor paconn returns an error when adding titles at the parameter level:

image

When removed, no errors returned.

- Removed title from parameters, paconn threw errors
@krautrocker
Copy link
Contributor Author

Hi @krautrocker,

Please refer the below link the title and the description must be in English.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission#give-your-connector-a-title

@vmanoharas All set, made updates to title and description.

@krautrocker krautrocker changed the title Proposal - Bundestag (Independent Publisher) Proposal - German Parliament (Independent Publisher) Mar 14, 2025
@vmanoharas
Copy link
Contributor

Hi @krautrocker,
Please refer the below link the title and the description must be in English.
https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission#give-your-connector-a-title

@vmanoharas All set, made updates to title and description.

Hi @krautrocker,

The PR title still has Proposal word, kindly update it.

@krautrocker krautrocker changed the title Proposal - German Parliament (Independent Publisher) German Parliament (Independent Publisher) Mar 19, 2025
@krautrocker
Copy link
Contributor Author

Hi @krautrocker,

Please refer the below link the title and the description must be in English.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission#give-your-connector-a-title

@vmanoharas All set, made updates to title and description.

Hi @krautrocker,

The PR title still has Proposal word, kindly update it.

Done, thank you!

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @krautrocker,

Please resolve review comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants