-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German Parliament (Independent Publisher) #3783
base: dev
Are you sure you want to change the base?
German Parliament (Independent Publisher) #3783
Conversation
- paconn validated, no errors.
Hi Dan,
|
…ers it. - Added titles to parameters
Thanks, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krautrocker,
Please change all the German strings to English before we proceed for the review. However, please note that your connector will be translated to different languages once it is certified and eligible for the translation.
Ah, I see! Will the terms be auto translated or translated by a human? Curious, as I'm a German speaker. Pretty cool, regardless. Which strings need to be changed? Action names (Ex: Vorgangspositionen), summary prefixes (Ex: Vorgänge - ...), everywhere except the actual field names, I assume? |
…lations to be handled once approved
Yes @krautrocker, the strings will be translated by our internal Localization team. Yes except actions and triggers, please change to English. |
@vmanoharas Beautiful, thank you. I did make an update yesterday that removed strings from the readme and the short strings that were at the start of action names to make them only English. I'll change the operation IDs to reflect the English equivalents as well. Lastly, I'll change the title "Deutscher Bundestag" to "German Bundestag." Do let me know if I need to change anything else. |
Hi @krautrocker, Please refer the below link the title and the description must be in English. |
@troystaylor paconn returns an error when adding titles at the parameter level: When removed, no errors returned. |
- Removed title from parameters, paconn threw errors
@vmanoharas All set, made updates to title and description. |
Hi @krautrocker, The PR title still has Proposal word, kindly update it. |
Done, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @krautrocker,
Please resolve review comment.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: