Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specification language to describe flat conversions and aggregate splats. #358

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Specification language to describe flat conversions and aggregate splats. #358

wants to merge 7 commits into from

Conversation

spall
Copy link
Collaborator

@spall spall commented Dec 16, 2024

Specification language to describe flat conversions and aggregate splats.

@spall
Copy link
Collaborator Author

spall commented Dec 16, 2024

@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree company="Microsoft"

@llvm-beanz llvm-beanz added the Design Meeting Agenda item for the design meeting label Jan 18, 2025
@llvm-beanz llvm-beanz mentioned this pull request Jan 23, 2025
Open
llvm-beanz
llvm-beanz reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please doublecheck which conversions are allowed to produce cxvalues vs which conversions can only produce prvalues.

@github-actions github-actions bot added the language-spec Issue with completed spec label Feb 28, 2025
V-FEXrt
V-FEXrt reviewed Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@V-FEXrt V-FEXrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will leave Chris to approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llvm-beanz llvm-beanz llvm-beanz left review comments

@V-FEXrt V-FEXrt V-FEXrt approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Design Meeting Agenda item for the design meeting language-spec Issue with completed spec
Projects
HLSL Language Features
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spall @V-FEXrt @llvm-beanz