[0002] Specify the grammar formulations for attributes #65
Conversation
| all shared grammar elements between HLSL and C++. This spec attempts to detail | ||
| some of the grammar and parsing implications and will specify the process by | ||
| which existing attributes will convert to C++ attributes. | ||
| ### Attribute Parsing |
There was a problem hiding this comment.
Best to add a blank line before the section header for the benefit of those reading the markdown directly (I don't think it makes a difference in the rendered doc)
proposals/0002-cxx-attributes.md
Outdated
| which existing attributes will convert to C++ attributes. | ||
| ### Attribute Parsing | ||
|
|
||
| This proposal introduces new grammar formulations for parsing attributes |
There was a problem hiding this comment.
I'd probably drop the word "new" - "introduces grammar formulations" is clear
proposals/0002-cxx-attributes.md
Outdated
| ``` | ||
|
|
||
| In contrast to existing HLSL annotations and Microsoft-style attributes, these | ||
| attribute identifiers are case-sensitive `identifier` tokens. |
There was a problem hiding this comment.
This is probably clear enough from context and I'm just being pedantic, but "attribute identifiers are case-sensitive identifier tokens" isn't strictly true (there's also the attribute-scoped-token formulation).
Maybe:
In contrast to existing HLSL annotations and Microsoft-style attributes, these formulations use case-sensitive
identifiertokens
llvm-beanz
changed the title
proposals/0002-cxx-attributes.md
Outdated
| ```ebnf | ||
| attribute-specifier-seq: [ attribute-specifier-seq ], attribute-specifier | ||
| attribute-specifier: "[" , "[" , attribute-list , "]" , "]" | ||
| attribute-list: [ attribute ] || |
There was a problem hiding this comment.
If one of the options for attribute-list is an optional attribute that means [[]] will parse as attribute-specifier(attribute-list(optional-attribute = none)) is that an intended spelling?
This does not exhaustively express all the places C++ attributes are valid, but it should cover enough detail to be useful. Fixes microsoft#63.
This updates the grammar specification to align with how C++ specifies parsing grammar, and the language spec latex is included. I've also added images containing the rendered grammar for ease of reading.
llvm-beanz
force-pushed
the
cbieneman/case-sensitive-attrs
branch
from
8b194ea to
059b06f
Compare
| \textit{simple-template-id}\br | ||
|
|
||
| \define{class-specifier}\br | ||
| \textit{class-head} \terminal{\}} \opt{member-specification} \terminal{\}}\br |
There was a problem hiding this comment.
typo?
| \textit{class-head} \terminal{\}} \opt{member-specification} \terminal{\}}\br | |
| \textit{class-head} \terminal{\{} \opt{member-specification} \terminal{\}}\br | |
This does not exhaustively express all the places C++ attributes are valid, but it should cover enough detail to be useful.
Fixes #63.