-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding backport labels to filesync, and dependabot PRs #399
base: main
Are you sure you want to change the base?
Adding backport labels to filesync, and dependabot PRs #399
Conversation
.github/dependabot.yml
Outdated
@@ -39,6 +39,7 @@ updates: | |||
labels: | |||
- "type:dependencies" | |||
- "type:dependabot" | |||
- "type:backport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A backport label in a repo that doesn't have the dev/release split should not pose a problem, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't cause scripts or anything to act on the label, but it would be confusing to a user.
You'd need to update the synced template files anyway in .sync/dependabot. So, you could make those be Nunjucks templates and provide an optional parameter to add this label. And then break out the repos that have the dev/release branch split in .sync/Files.yml
to include it during the sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apop5, are you planning to follow up with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just trying to finish up a couple of other things and will get back to this.
5302b10
to
de38cc8
Compare
@apop5, I'll review when it comes out of draft. |
Filesync and Dependabot are creating Prs for the dev branches.
This allows dev to become out of sync with release branches.
Adding Backport labels to the PRs generated by filesync and dependabot.