Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding backport labels to filesync, and dependabot PRs #399

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Feb 4, 2025

Filesync and Dependabot are creating Prs for the dev branches.

This allows dev to become out of sync with release branches.

Adding Backport labels to the PRs generated by filesync and dependabot.

@@ -39,6 +39,7 @@ updates:
labels:
- "type:dependencies"
- "type:dependabot"
- "type:backport"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makubacki

A backport label in a repo that doesn't have the dev/release split should not pose a problem, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't cause scripts or anything to act on the label, but it would be confusing to a user.

You'd need to update the synced template files anyway in .sync/dependabot. So, you could make those be Nunjucks templates and provide an optional parameter to add this label. And then break out the repos that have the dev/release branch split in .sync/Files.yml to include it during the sync.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apop5, are you planning to follow up with this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just trying to finish up a couple of other things and will get back to this.

@apop5 apop5 requested review from makubacki and Javagedes February 4, 2025 16:45
@apop5 apop5 marked this pull request as draft March 10, 2025 20:03
@apop5 apop5 force-pushed the personal/apop5/addbackporttofileanddependabot branch from 5302b10 to de38cc8 Compare March 10, 2025 20:55
@makubacki
Copy link
Member

@apop5, I'll review when it comes out of draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants