Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a string for browse path not found #13372

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Conversation

Colengms
Copy link
Contributor

No description provided.

@Colengms Colengms requested a review from a team as a code owner March 14, 2025 00:33
sean-mcmanus
sean-mcmanus previously approved these changes Mar 14, 2025
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to confuse anyone who doesn't have it set specifically as a browse.path? This error appears whenever a -I refers to an non-exist path, which could be in an @rsp file referenced in a compile_commands.json.

@Colengms
Copy link
Contributor Author

Colengms commented Mar 14, 2025

@sean-mcmanus Do you have a better suggestion? This is a browse path. There is no context at this point as to what the source of the browse path was. It could be a compile_commands arguments, a path from a custom configuration provider, an include path, an explicit browse path... anything.

@bobbrow
Copy link
Member

bobbrow commented Mar 14, 2025

How about "Unable to index files from non-existent folder: {0}"

@Colengms Colengms merged commit 301f9a6 into main Mar 14, 2025
6 checks passed
@Colengms Colengms deleted the coleng/browse_path_not_found branch March 14, 2025 20:51
@sean-mcmanus sean-mcmanus added this to the 1.24.3 milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants