Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earcut: Copy mapbox/earcut file into core libs #30756

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #30737 (comment)

Description

Copy the earcut file as directly as possible rather than modify or import to enable easy updates while keeping all core files external-dependency-free.

@gkjohnson gkjohnson requested a review from Mugen87 March 19, 2025 01:32
Copy link

github-actions bot commented Mar 19, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26
336.02
78.26
+0 B
+0 B
WebGPU 525.13
146.26
525.13
146.26
+0 B
+0 B
WebGPU Nodes 524.59
146.16
524.59
146.16
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.07
112.14
465.07
112.14
+0 B
+0 B
WebGPU 597.91
162.53
597.91
162.53
+0 B
+0 B
WebGPU Nodes 553.03
152.01
553.03
152.01
+0 B
+0 B

@gkjohnson gkjohnson added this to the r175 milestone Mar 19, 2025
@Mugen87 Mugen87 merged commit e6b3f2d into mrdoob:dev Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants