MBS-11760: Improve testing for tag autodeletion

These were not testing the ON DELETE triggers at all,
since the first "commit" only sees that the inserted tag
is not being used via the ON INSERT trigger.
That meant entities where the ON DELETE trigger was missing
(release, recording) still showed as working fine.
Additionally, several entities were not being tested at all.

Author: reosarevok

t/pgtap/unused-tags/unused-area-tags-deleted.sql

@@ -0,0 +1,46 @@
+SET search_path = 'musicbrainz', 'public';
+
+--------------------------------------------------------------------------------
+BEGIN;
+SELECT no_plan();
+
+INSERT INTO area (id, gid, name, comment)
+  VALUES (1, '82ac9811-db47-4c05-9792-83cf4208afd0', 'Area', 'Area 1'),
+         (2, '9baea67a-8d86-422d-b653-b0f6d0a93c7c', 'Area', 'Area 2');
+
+INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Shared tag');
+INSERT INTO area_tag (area, tag, count) VALUES
+  (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
+
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
+DELETE FROM area_tag WHERE tag = 2;
+
+-- Deleting but the re-adding should not garbage collect
+DELETE FROM area_tag WHERE tag = 4;
+INSERT INTO area_tag (area, tag, count) VALUES (1, 4, 1);
+
+DELETE FROM area_tag WHERE tag = 5 AND area = 1;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{2, 4, 5}'::INT[],
+  'Tag exists before commit'
+);
+
+-- Simulate the commit
+SET CONSTRAINTS ALL IMMEDIATE;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4, 5}'::INT[],
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON area_tag trigger
+DELETE FROM area_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON area_tag'
+);
+
+SELECT finish();
+ROLLBACK;

t/pgtap/unused-tags/unused-artist-tags-deleted.sql

@@ -12,6 +12,7 @@ INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Share
 INSERT INTO artist_tag (artist, tag, count) VALUES
   (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
 
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
 DELETE FROM artist_tag WHERE tag = 2;
 
 -- Deleting but the re-adding should not garbage collect
@@ -30,7 +31,15 @@ SET CONSTRAINTS ALL IMMEDIATE;
 
 SELECT set_eq(
   'SELECT id FROM tag', '{4, 5}'::INT[],
-  'Tag collected after commit'
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON artist_tag trigger
+DELETE FROM artist_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON artist_tag'
 );
 
 SELECT finish();

t/pgtap/unused-tags/unused-event-tags-deleted.sql

@@ -0,0 +1,46 @@
+SET search_path = 'musicbrainz', 'public';
+
+--------------------------------------------------------------------------------
+BEGIN;
+SELECT no_plan();
+
+INSERT INTO event (id, gid, name, comment)
+  VALUES (1, '82ac9811-db47-4c05-9792-83cf4208afd0', 'Event', 'Event 1'),
+         (2, '9baea67a-8d86-422d-b653-b0f6d0a93c7c', 'Event', 'Event 2');
+
+INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Shared tag');
+INSERT INTO event_tag (event, tag, count) VALUES
+  (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
+
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
+DELETE FROM event_tag WHERE tag = 2;
+
+-- Deleting but the re-adding should not garbage collect
+DELETE FROM event_tag WHERE tag = 4;
+INSERT INTO event_tag (event, tag, count) VALUES (1, 4, 1);
+
+DELETE FROM event_tag WHERE tag = 5 AND event = 1;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{2, 4, 5}'::INT[],
+  'Tag exists before commit'
+);
+
+-- Simulate the commit
+SET CONSTRAINTS ALL IMMEDIATE;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4, 5}'::INT[],
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON event_tag trigger
+DELETE FROM event_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON event_tag'
+);
+
+SELECT finish();
+ROLLBACK;

t/pgtap/unused-tags/unused-instrument-tags-deleted.sql

@@ -0,0 +1,46 @@
+SET search_path = 'musicbrainz', 'public';
+
+--------------------------------------------------------------------------------
+BEGIN;
+SELECT no_plan();
+
+INSERT INTO instrument (id, gid, name, comment)
+  VALUES (1, '82ac9811-db47-4c05-9792-83cf4208afd0', 'Instrument', 'Instrument 1'),
+         (2, '9baea67a-8d86-422d-b653-b0f6d0a93c7c', 'Instrument', 'Instrument 2');
+
+INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Shared tag');
+INSERT INTO instrument_tag (instrument, tag, count) VALUES
+  (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
+
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
+DELETE FROM instrument_tag WHERE tag = 2;
+
+-- Deleting but the re-adding should not garbage collect
+DELETE FROM instrument_tag WHERE tag = 4;
+INSERT INTO instrument_tag (instrument, tag, count) VALUES (1, 4, 1);
+
+DELETE FROM instrument_tag WHERE tag = 5 AND instrument = 1;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{2, 4, 5}'::INT[],
+  'Tag exists before commit'
+);
+
+-- Simulate the commit
+SET CONSTRAINTS ALL IMMEDIATE;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4, 5}'::INT[],
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON instrument_tag trigger
+DELETE FROM instrument_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON instrument_tag'
+);
+
+SELECT finish();
+ROLLBACK;

t/pgtap/unused-tags/unused-label-tags-deleted.sql

@@ -12,6 +12,7 @@ INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Share
 INSERT INTO label_tag (label, tag, count) VALUES
   (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
 
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
 DELETE FROM label_tag WHERE tag = 2;
 
 -- Deleting but the re-adding should not garbage collect
@@ -30,8 +31,15 @@ SET CONSTRAINTS ALL IMMEDIATE;
 
 SELECT set_eq(
   'SELECT id FROM tag', '{4, 5}'::INT[],
-  'Tag collected after commit'
+  'Tag deleted after commit by AFTER INSERT ON tag'
 );
 
+-- Delete tag after commit to test AFTER DELETE ON label_tag trigger
+DELETE FROM label_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON label_tag');
+
 SELECT finish();
 ROLLBACK;

t/pgtap/unused-tags/unused-place-tags-deleted.sql

@@ -0,0 +1,46 @@
+SET search_path = 'musicbrainz', 'public';
+
+--------------------------------------------------------------------------------
+BEGIN;
+SELECT no_plan();
+
+INSERT INTO place (id, gid, name, comment)
+  VALUES (1, '82ac9811-db47-4c05-9792-83cf4208afd0', 'Place', 'Place 1'),
+         (2, '9baea67a-8d86-422d-b653-b0f6d0a93c7c', 'Place', 'Place 2');
+
+INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Shared tag');
+INSERT INTO place_tag (place, tag, count) VALUES
+  (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
+
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
+DELETE FROM place_tag WHERE tag = 2;
+
+-- Deleting but the re-adding should not garbage collect
+DELETE FROM place_tag WHERE tag = 4;
+INSERT INTO place_tag (place, tag, count) VALUES (1, 4, 1);
+
+DELETE FROM place_tag WHERE tag = 5 AND place = 1;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{2, 4, 5}'::INT[],
+  'Tag exists before commit'
+);
+
+-- Simulate the commit
+SET CONSTRAINTS ALL IMMEDIATE;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4, 5}'::INT[],
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON place_tag trigger
+DELETE FROM place_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON place_tag'
+);
+
+SELECT finish();
+ROLLBACK;

t/pgtap/unused-tags/unused-recording-tags-deleted.sql

@@ -14,6 +14,7 @@ INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Share
 INSERT INTO recording_tag (recording, tag, count) VALUES
   (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
 
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
 DELETE FROM recording_tag WHERE tag = 2;
 
 -- Deleting but the re-adding should not garbage collect
@@ -32,7 +33,15 @@ SET CONSTRAINTS ALL IMMEDIATE;
 
 SELECT set_eq(
   'SELECT id FROM tag', '{4, 5}'::INT[],
-  'Tag collected after commit'
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON recording_tag trigger
+DELETE FROM recording_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON recording_tag'
 );
 
 SELECT finish();

t/pgtap/unused-tags/unused-release-group-tags-deleted.sql

@@ -14,6 +14,7 @@ INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Share
 INSERT INTO release_group_tag (release_group, tag, count) VALUES
   (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
 
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
 DELETE FROM release_group_tag WHERE tag = 2;
 
 -- Deleting but the re-adding should not garbage collect
@@ -32,8 +33,15 @@ SET CONSTRAINTS ALL IMMEDIATE;
 
 SELECT set_eq(
   'SELECT id FROM tag', '{4, 5}'::INT[],
-  'Tag collected after commit'
+  'Tag deleted after commit by AFTER INSERT ON tag'
 );
 
+-- Delete tag after commit to test AFTER DELETE ON release_group_tag trigger
+DELETE FROM release_group_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON release_group_tag');
+
 SELECT finish();
 ROLLBACK;

t/pgtap/unused-tags/unused-release-tags-deleted.sql

@@ -17,6 +17,7 @@ INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Share
 INSERT INTO release_tag (release, tag, count) VALUES
   (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
 
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
 DELETE FROM release_tag WHERE tag = 2;
 
 -- Deleting but the re-adding should not garbage collect
@@ -35,8 +36,15 @@ SET CONSTRAINTS ALL IMMEDIATE;
 
 SELECT set_eq(
   'SELECT id FROM tag', '{4, 5}'::INT[],
-  'Tag collected after commit'
+  'Tag deleted after commit by AFTER INSERT ON tag'
 );
 
+-- Delete tag after commit to test AFTER DELETE ON release_tag trigger
+DELETE FROM release_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON release_tag');
+
 SELECT finish();
 ROLLBACK;

t/pgtap/unused-tags/unused-series-tags-deleted.sql

@@ -0,0 +1,46 @@
+SET search_path = 'musicbrainz', 'public';
+
+--------------------------------------------------------------------------------
+BEGIN;
+SELECT no_plan();
+
+INSERT INTO series (id, gid, name, comment, type, ordering_attribute, ordering_type)
+  VALUES (1, '82ac9811-db47-4c05-9792-83cf4208afd0', 'Series', 'Series 1', 1, 788, 1),
+         (2, '9baea67a-8d86-422d-b653-b0f6d0a93c7c', 'Series', 'Series 2', 1, 788, 1);
+
+INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Shared tag');
+INSERT INTO series_tag (series, tag, count) VALUES
+  (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
+
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
+DELETE FROM series_tag WHERE tag = 2;
+
+-- Deleting but the re-adding should not garbage collect
+DELETE FROM series_tag WHERE tag = 4;
+INSERT INTO series_tag (series, tag, count) VALUES (1, 4, 1);
+
+DELETE FROM series_tag WHERE tag = 5 AND series = 1;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{2, 4, 5}'::INT[],
+  'Tag exists before commit'
+);
+
+-- Simulate the commit
+SET CONSTRAINTS ALL IMMEDIATE;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4, 5}'::INT[],
+  'Tag deleted after commit by AFTER INSERT ON tag'
+);
+
+-- Delete tag after commit to test AFTER DELETE ON series_tag trigger
+DELETE FROM series_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON series_tag'
+);
+
+SELECT finish();
+ROLLBACK;

t/pgtap/unused-tags/unused-work-tags-deleted.sql

@@ -12,6 +12,7 @@ INSERT INTO tag (id, name) VALUES (2, 'Unused tag'), (4, 'Used tag'), (5, 'Share
 INSERT INTO work_tag (work, tag, count) VALUES
   (1, 2, 1), (1, 4, 1), (1, 5, 1), (2, 5, 1);
 
+-- Delete tag before commit to test AFTER INSERT ON tag trigger
 DELETE FROM work_tag WHERE tag = 2;
 
 -- Deleting but the re-adding should not garbage collect
@@ -30,8 +31,15 @@ SET CONSTRAINTS ALL IMMEDIATE;
 
 SELECT set_eq(
   'SELECT id FROM tag', '{4, 5}'::INT[],
-  'Tag collected after commit'
+  'Tag deleted after commit by AFTER INSERT ON tag'
 );
 
+-- Delete tag after commit to test AFTER DELETE ON work_tag trigger
+DELETE FROM work_tag WHERE tag = 5;
+
+SELECT set_eq(
+  'SELECT id FROM tag', '{4}'::INT[],
+  'Tag deleted after commit by AFTER DELETE ON work_tag');
+
 SELECT finish();
 ROLLBACK;