Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular to v9 #519

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Update Angular to v9 #519

merged 1 commit into from
Apr 28, 2020

Conversation

mattarau
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:
    Framework Update (from Angular v7.x to Angular v9.x)

What is the current behavior?

The library was not compatible with Angular 9

Issue Number: #517

What is the new behavior?

The library now can be installed in Angular 9 projects

Does this PR introduce a breaking change?

[X] Yes
[ ] No

The update makes the library only compatible with Angular 9+ projects

Other information

@neroniaky
Copy link
Owner

Thanks! I will take a look at it tomorrow.

@neroniaky
Copy link
Owner

Sorry for the delay. I did not forget. On it.

@bhushangahire
Copy link

Any update on this?

@charliee22
Copy link

would love to see an update on this

@bhushangahire
Copy link

@neroniaky Any update?

@neroniaky neroniaky merged commit 5d39201 into neroniaky:master Apr 28, 2020
@neroniaky
Copy link
Owner

Sorry again for the long wait.

@bhushangahire
Copy link

What is the version to use for this? The latest I am getting 7.0.1

@neroniaky
Copy link
Owner

@bhushangahire I published it under the next tag not latest, so you have to specify 9.0.0-beta.0
See: https://www.npmjs.com/package/angular-token/v/9.0.0-beta.0

@bhushangahire
Copy link

Great I can see it now. Thanks, Stay Safe.

neroniaky added a commit that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants