New Phoenix Contact modbus UPS models

[RikyPlaza]

Management of new Phoenix Contact UPS models.

[AppVeyorBot]

❌ Build nut 2.8.2.2877-master failed (commit 1859212d9b by @RikyPlaza)

[RikyPlaza]

No idea why these errors are coming up now :(
On last PR this code was already present and no errors were raised by the compiler.

[jimklimov]

Previously you were sending address of uint16_t to mrir() and now you send address of array, but the method signature seems not changed. Did you mean to read the register into just the zero'th element? Or did you drop the other 4 mrir lines by mistake?

[jimklimov]

Sanity check: are you sure maths are not truncated here by a 16-bit number?

What does this multiplication achieve? (A bit shift would be more idiomatic)

[AppVeyorBot]

❌ Build nut 2.8.2.2888-master failed (commit 38b94f9089 by @RikyPlaza)

[jimklimov]

  CC       phoenixcontact_modbus.o
phoenixcontact_modbus.c: In function ‘upsdrv_updateinfo’:
phoenixcontact_modbus.c:31:28: error: overflow in conversion from ‘int’ to ‘uint16_t’ {aka ‘short unsigned int’} changes value from ‘(int)actual_code_functions2 & 262144’ to ‘0’ [-Werror=overflow]
   31 | #define CHECK_BIT(var,pos) ((var) & (1<<(pos)))
      |                            ^
phoenixcontact_modbus.c:248:30: note: in expansion of macro ‘CHECK_BIT’
  248 |                 tab_reg[1] = CHECK_BIT(actual_code_functions2, 18);
      |                              ^~~~~~~~~
  GENERATE-HEADER	nut_version.h

What is the expected value of tab_reg[1] after this - 0-or-1, or the selected bit as such?
As coded, you ask for 18th bit and save it as such into a 16-bit word...