Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when updating config concurrently #1013

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix panic when updating config concurrently #1013

wants to merge 3 commits into from

Conversation

bejjrajesh
Copy link

@bejjrajesh bejjrajesh commented Mar 19, 2025 •
edited
Loading

Proposed changes

This MR will fix the panic error happen when updating the nginx config concurrently.
image

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@bejjrajesh bejjrajesh requested a review from a team as a code owner March 19, 2025 14:26
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@bejjrajesh
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@dhurley dhurley changed the title fix: fixing panic when updating config concurrently Fix panic when updating config concurrently Mar 19, 2025
@dhurley dhurley added the v2.x Issues and Pull Requests related to the major version v2 label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@aphralG aphralG aphralG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bejjrajesh @dhurley @aphralG