zero each kafka span before populating #1937
Open
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
reviewed
Mar 5, 2025
|
|
||
| u32 actual_id = 1; | ||
| // Zero the span we are about to build, eBPF doesn't support memset of large structs (more than 1024 bytes) | ||
| bpf_map_update_elem(&kafka_request_storage_map, &actual_id, zero_kafka_request, 0); |
There was a problem hiding this comment.
Very clever trick! should the update have BPF_ANY instead of 0? I don't think it would ever fail, but maybe it's worth checking if the update succeeded.
There was a problem hiding this comment.
updated to use BPF_ANY.
regarding error handling, not sure if we should drop the span if we failed to zero the memory or not.
MrAlias
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.