Move process Info creation into NewManager #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
mv-proc-info-to-mngr
branch
3 times, most recently
from
232f00d to
8a30f48
Compare
MrAlias
force-pushed
the
mv-proc-info-to-mngr
branch
from
8a30f48 to
9f74911
Compare
The Manager manages probes for a process. Have the manager handle the process info creation and coordination instead of extraneously passing it from the Instrumentation.
MrAlias
force-pushed
the
mv-proc-info-to-mngr
branch
from
9f74911 to
d80e6f9
Compare
damemi
reviewed
Mar 7, 2025
RonFed
approved these changes
Mar 9, 2025
damemi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Manager manages probes for a process. Have the manager handle the process info creation and coordination instead of extraneously passing it from the
Instrumentation.