Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e tests on arm #1965

Merged
merged 8 commits into from
Mar 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,32 @@ on:

jobs:
build-auto-instrumentation:
runs-on: ubuntu-latest
strategy:
matrix:
runner: [ubuntu-latest, ubuntu-22.04-arm]
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout Repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- name: Build auto-instrumentation
run: |
IMG=otel-go-instrumentation:latest make docker-build
docker save otel-go-instrumentation:latest -o otel-go-instrumentation.tar
docker save otel-go-instrumentation:latest -o otel-go-instrumentation-${{ matrix.runner }}.tar
- name: Upload Docker image artifact
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
with:
name: otel-go-instrumentation
path: otel-go-instrumentation.tar
name: otel-go-instrumentation-${{ matrix.runner }}
path: otel-go-instrumentation-${{ matrix.runner }}.tar

kubernetes-test:
needs:
- build-auto-instrumentation
strategy:
matrix:
k8s-version: ["v1.26.0"]
library: ["autosdk", "nethttp", "nethttp_custom", "gin", "databasesql", "grpc", "otelglobal", "kafka-go"]
runs-on: ubuntu-latest
runner: [ubuntu-latest, ubuntu-22.04-arm]
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout Repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Expand Down Expand Up @@ -58,10 +63,10 @@ jobs:
- name: Download Docker image artifact
uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806 # v4
with:
name: otel-go-instrumentation
name: otel-go-instrumentation-${{ matrix.runner }}
- name: Load Docker image
run: |
docker load -i otel-go-instrumentation.tar
docker load -i otel-go-instrumentation-${{ matrix.runner }}.tar
- name: Kind load images
run: |
kind load docker-image otel-go-instrumentation --name chart-testing
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/autosdk/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/databasesql/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/gin/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/grpc/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/kafka-go/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/nethttp/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/nethttp_custom/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/otelglobal/traces.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.24.1 linux/amd64"
"stringValue": "go version 1.24.1 linux/VALID_ARCH"
}
},
{
Expand Down
6 changes: 6 additions & 0 deletions internal/test/test_helpers/utilities.sh
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ redact_json() {
end
| .resourceSpans[].scopeSpans|=sort_by(.scope.name)
| .resourceSpans[].scopeSpans[].spans|=sort_by(.kind)
| .resourceSpans[].resource.attributes[]? |= if
(.key == "process.runtime.description") then
.value.stringValue |= sub("amd64|arm64"; "VALID_ARCH")
else
.
end
' > ${BATS_TEST_DIRNAME}/traces.json
}

Expand Down
Loading