Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asyncclick instrumentation #3319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jomcgi
Copy link
Contributor

@jomcgi jomcgi commented Mar 2, 2025

Description

  • Add instrumentation for asyncclick based CLI apps
  • Add tox
  • Add Changelog
  • Update workflows

This implementation is based on the original click instrumentation work by:

Fixes #3318

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • tox -e test-instrumentation-asyncclick

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch from 874ba33 to 17b14da Compare March 2, 2025 22:03
@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch 5 times, most recently from a1b5c89 to ff0d7fd Compare March 2, 2025 23:36
@jomcgi jomcgi changed the title [WIP] Add asyncclick instrumentation Add asyncclick instrumentation Mar 2, 2025
@jomcgi jomcgi changed the title Add asyncclick instrumentation [WIP] Add asyncclick instrumentation Mar 3, 2025
@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch 5 times, most recently from 23d64e8 to bac1c1b Compare March 3, 2025 13:54
@github-actions github-actions bot requested a review from nemoshlag March 3, 2025 13:54
@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch from d0b2350 to ae61899 Compare March 5, 2025 21:52
@jomcgi jomcgi changed the title [WIP] Add asyncclick instrumentation Add asyncclick instrumentation Mar 5, 2025
@jomcgi jomcgi marked this pull request as ready for review March 5, 2025 22:15
@jomcgi jomcgi requested a review from a team as a code owner March 5, 2025 22:15
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt add that to the pyright strict list in pyproject.toml?

@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch from ae61899 to f0759b7 Compare March 12, 2025 09:16
@jomcgi
Copy link
Contributor Author

jomcgi commented Mar 12, 2025

wdyt add that to the pyright strict list in pyproject.toml?

Done!

@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch from f0759b7 to 9d09175 Compare March 12, 2025 09:24
* Add instrumentation for asyncclick based CLI apps
* Add tox
* Add Changelog
* Update workflows

This implementation is based on the original click instrumentation work by:
- Emídio Neto <[email protected]>
- Anuraag (Rag) Agrawal <[email protected]>
- Riccardo Magliocchetti <[email protected]>
@jomcgi jomcgi force-pushed the feat-3318/asyncclick-autoinstrumentation branch from 9d09175 to 69d88e3 Compare March 13, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: automatic instrumentation for asyncclick
4 participants