-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asyncclick instrumentation #3319
Open
jomcgi
wants to merge
1
commit into
open-telemetry:main
Choose a base branch
from
jomcgi:feat-3318/asyncclick-autoinstrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add asyncclick instrumentation #3319
jomcgi
wants to merge
1
commit into
open-telemetry:main
from
jomcgi:feat-3318/asyncclick-autoinstrumentation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
874ba33
to
17b14da
Compare
a1b5c89
to
ff0d7fd
Compare
23d64e8
to
bac1c1b
Compare
d0b2350
to
ae61899
Compare
xrmx
reviewed
Mar 7, 2025
...elemetry-instrumentation-asyncclick/src/opentelemetry/instrumentation/asyncclick/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt add that to the pyright strict list in pyproject.toml?
instrumentation/opentelemetry-instrumentation-asyncclick/README.rst
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-asyncclick/src/opentelemetry/instrumentation/asyncclick/__init__.py
Outdated
Show resolved
Hide resolved
ae61899
to
f0759b7
Compare
Done! |
f0759b7
to
9d09175
Compare
* Add instrumentation for asyncclick based CLI apps * Add tox * Add Changelog * Update workflows This implementation is based on the original click instrumentation work by: - Emídio Neto <[email protected]> - Anuraag (Rag) Agrawal <[email protected]> - Riccardo Magliocchetti <[email protected]>
9d09175
to
69d88e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implementation is based on the original click instrumentation work by:
Fixes #3318
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.