Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use bare-metal OTEL runners for benchmark CI #2813

Closed
wants to merge 1 commit into from

Conversation

scottgerring
Copy link
Contributor

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.3%. Comparing base (1bce83f) to head (18e8718).
Report is 11 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2813   +/-   ##
=====================================
  Coverage   80.3%   80.3%           
=====================================
  Files        124     124           
  Lines      23333   23333           
=====================================
+ Hits       18754   18758    +4     
+ Misses      4579    4575    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring
Copy link
Contributor Author

scottgerring commented Mar 17, 2025

Following on from open-telemetry/community/issues/2616 , this PR moves our criterion suite to use the self-hosted OTEL runners. Waiting to see it run through once successfully before marking ready-for-review.

Also noted in the golang benchmarks, that the jobs themselves can output markdown. This would solve our "can't annotate the PR with results" thing nicely. Will try work out what we're missing for this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants