-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: context stabilization tests & logging pieces #2833
chore: context stabilization tests & logging pieces #2833
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
=======================================
+ Coverage 80.7% 80.8% +0.1%
=======================================
Files 124 124
Lines 23490 23743 +253
=======================================
+ Hits 18961 19200 +239
- Misses 4529 4543 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ization' into chore/context-stabilization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only some comments about the test_out_of_order_context_detachment_futures
.
@@ -4,6 +4,9 @@ | |||
/// **internally within OpenTelemetry code** or for **custom exporters, processors and other plugins**. They are not designed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here cause the macros to print to stdout if you are running in a test. I find it super convenient to see internal logging when debugging tests. You need to opt into this with --nocapture
when you run them, otherwise the output goes to /dev/null
.
@@ -25,7 +28,13 @@ macro_rules! otel_info { | |||
{ | |||
tracing::info!( name: $name, target: env!("CARGO_PKG_NAME"), name = $name, ""); | |||
} | |||
#[cfg(not(feature = "internal-logs"))] | |||
|
|||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good idea. Let us do this in a separate PR, as there are some tests which setup fmt layer already, and we need to discontinue that to avoid the duplication to stdout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2841 opened to check this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cijothomas great - thanks! I'll chase this up.
Fixes #2768
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes