-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tooltips to registry #5351
add tooltips to registry #5351
Conversation
looks good, thank you! There are a lot of changes to the formatting in the file that are unrelated to your work. Can you make sure that you only have changes relevant to your work. Probably your editor applied some formatting, you might be able to revert that by running |
sure I will do it |
@crocmons there is still some formatting applied that shouldn't be there, has the local fixing worked? I also see that you have some unrelated changes for a git submodule, you can remove that by running Maybe give |
Hello @svrnm I have fixed the formatting manually..can you now take a look at it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good so far! See my inline comments for more improvements.
This reverts commit f6073b9.
6812122
to
7e91364
Compare
Hi @chalin, I hope you're doing well. I fixed all the changes that you mentioned to resolve it. Hopefully, now it works as expected, but I appreciate your guidance. Please let me know if you find any further issues, and I'll fix them soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to work towards taking that PR in.
Can you make sure that there are no changes left that are unrelated to this PR (especially formating of the entry.html file), because this makes it really hard to spot all the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a help page is a good idea, but something that should be part of a dedicated PR, can you remove this from this PR for now? If you like to help with that feel free to raise another PR adding this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
{{ | ||
$remoteRegistries := dict | ||
"npm" (dict | ||
"urlPattern" "https://npmjs.com/package/%s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"installLine" "npm install %s" | ||
"icon" "fab fa-npm") | ||
"packagist" (dict | ||
"urlPattern" "https://packagist.org/packages/%s" | ||
"installLine" "composer require %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-solid fa-box-open") | ||
"gems" (dict | ||
"urlPattern" "https://rubygems.org/gems/%s" | ||
"installLine" "gem install %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-solid fa-gem") | ||
"go" (dict | ||
"urlPattern" "https://pkg.go.dev/%s" | ||
"installLine" "go get %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-brands fa-golang") | ||
"go-collector" (dict | ||
"urlPattern" "https://pkg.go.dev/%s" | ||
"installTemplate" "ecosystem/registry/quickinstall/collector.md" | ||
"icon" "fa-solid fa-box-open") | ||
"nuget" (dict | ||
"urlPattern" "https://www.nuget.org/packages/%s" | ||
"installLine" "dotnet add package %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-solid fa-box-open") | ||
"pip" (dict | ||
"urlPattern" "https://pypi.org/project/%s" | ||
"installLine" "pip install %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-brands fa-python") | ||
"hex" (dict | ||
"urlPattern" "https://hex.pm/packages/%s" | ||
"installTemplate" "ecosystem/registry/quickinstall/hex.md" | ||
"icon" "fa-brands fa-erlang") | ||
"crates" (dict | ||
"urlPattern" "https://crates.io/crates/%s" | ||
"installLine" "cargo add %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fab fa-rust") | ||
-}} | ||
{{ | ||
$remoteRegistries := dict | ||
"npm" (dict | ||
"urlPattern" "https://npmjs.com/package/%s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"installLine" "npm install %s" | ||
"icon" "fab fa-npm") | ||
"packagist" (dict | ||
"urlPattern" "https://packagist.org/packages/%s" | ||
"installLine" "composer require %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-solid fa-box-open") | ||
"gems" (dict | ||
"urlPattern" "https://rubygems.org/gems/%s" | ||
"installLine" "gem install %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-solid fa-gem") | ||
"go" (dict | ||
"urlPattern" "https://pkg.go.dev/%s" | ||
"installLine" "go get %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-brands fa-golang") | ||
"go-collector" (dict | ||
"urlPattern" "https://pkg.go.dev/%s" | ||
"installTemplate" "ecosystem/registry/quickinstall/collector.md" | ||
"icon" "fa-solid fa-box-open") | ||
"nuget" (dict | ||
"urlPattern" "https://www.nuget.org/packages/%s" | ||
"installLine" "dotnet add package %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-solid fa-box-open") | ||
"pip" (dict | ||
"urlPattern" "https://pypi.org/project/%s" | ||
"installLine" "pip install %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fa-brands fa-python") | ||
"hex" (dict | ||
"urlPattern" "https://hex.pm/packages/%s" | ||
"installTemplate" "ecosystem/registry/quickinstall/hex.md" | ||
"icon" "fa-brands fa-erlang") | ||
"crates" (dict | ||
"urlPattern" "https://crates.io/crates/%s" | ||
"installLine" "cargo add %s" | ||
"installTemplate" "ecosystem/registry/quickinstall/default.md" | ||
"icon" "fab fa-rust") | ||
-}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this and other formatting changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -105,7 +106,7 @@ <h4 class="card-title mb-0 d-flex flex-row"> | |||
<span class="badge rounded-pill text-bg-secondary text-white" title="This package is used in the OpenTelemetry Demo!"><i class="fa-solid fa-shapes"></i> OTel Demo</span> | |||
{{ end -}} | |||
{{ if $deprecated -}} | |||
<span class="badge rounded-pill text-bg-danger text-white" title=""><i class="fa-solid fa-ban"></i> deprecated</span> | |||
<span class="badge rounded-pill text-bg-danger text-white" title="This package is deprecated. It is recommended to no longer use it and to look for a replacement if it is in use."><i class="fa-solid fa-ban"></i> deprecated</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add the data-bs-toogle as well?
{{ if eq (replace (lower .) " " "") "collector" }} | ||
<small data-bs-toggle="tooltip" | ||
title="Collector: This is an extension for the OpenTelemetry Collector."> | ||
<a href="https://opentelemetry.io/docs/collector/" target="_blank" class="text-muted">Collector</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="https://opentelemetry.io/docs/collector/" target="_blank" class="text-muted">Collector</a> | |
Collector |
skip the link for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
</small> | ||
{{ else }} | ||
<small data-bs-toggle="tooltip" title="This indicates the programming language used."> | ||
{{ . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ . }} | |
Language |
<small data-bs-toggle="tooltip" title="This refers to the type of registry component. For more details, visit our Help page."> | ||
<a href="https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/ecosystem/registry/help.md" target="_blank" class="text-muted">Component</a> | ||
</small> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's skip this for now
{{ if eq . "Commercial" }} | ||
<small data-bs-toggle="tooltip" | ||
title="Commercial License: This project has a commercial license. End users may need to check with the provider for specific usage rights and restrictions. For more details on common license types, visit the Open Source Initiative at opensource.org/licenses."> | ||
<a href="https://opensource.org/licenses" target="_blank" class="text-muted">License</a> | ||
</small> | ||
{{ else }} | ||
<small data-bs-toggle="tooltip" | ||
title="Open-Source License: This project is distributed under an open-source license. End users are encouraged to review the license terms to ensure compatibility with their usage. Visit the Open Source Initiative for more details."> | ||
<a href="https://opensource.org/licenses" target="_blank" class="text-muted">License</a> | ||
</small> | ||
{{ end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ if eq . "Commercial" }} | |
<small data-bs-toggle="tooltip" | |
title="Commercial License: This project has a commercial license. End users may need to check with the provider for specific usage rights and restrictions. For more details on common license types, visit the Open Source Initiative at opensource.org/licenses."> | |
<a href="https://opensource.org/licenses" target="_blank" class="text-muted">License</a> | |
</small> | |
{{ else }} | |
<small data-bs-toggle="tooltip" | |
title="Open-Source License: This project is distributed under an open-source license. End users are encouraged to review the license terms to ensure compatibility with their usage. Visit the Open Source Initiative for more details."> | |
<a href="https://opensource.org/licenses" target="_blank" class="text-muted">License</a> | |
</small> | |
{{ end }} | |
{{ if eq . "Commercial" }} | |
<small data-bs-toggle="tooltip" | |
title="Commercial License: This project has a commercial license. End users may need to check with the provider for specific usage rights and restrictions."> | |
License | |
</small> | |
{{ else }} | |
<small data-bs-toggle="tooltip" | |
title="Open-Source License: This project is distributed under an open-source license. End users are encouraged to review the license terms to ensure compatibility with their usage."> | |
License | |
</small> | |
{{ end }} |
Let's remove the links for now, we can improve on that in a later iteration
thanks for working on this during the outreachy application phase. This PR is stalled for a month now, so I will close it now. We also need to rethink if and how we want to have tool tips in the registry. |
This PR resolves this issue #5333 and adds tooltips to clarify the meaning of various categories (e.g., "Collector", "Application Integration", "Language", "License") in the component listing, improving user experience by providing contextual information.
Key Changes:
Language
,License
,Registry Type
).Example:
Testing:
Demo: