-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daily semconv build workflow #6034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ever workflow arguments are visible (e.g., logged), is GH smart enough to not show the value when it is meant to be a secret?
I tried to |
That |
it's not passed as a regular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, of course, now that I'm paying closer attention. Ok, LGTM.
Btw, we might want to see how we can tweak this so that it doesn't fail if the refcache is updated, only if there are broken links. That might be a project for another time.
Secrets are not automatically passed to reusable workflows
cc @open-telemetry/specs-semconv-maintainers