Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo repo links: fix & check them all, update refcache #6124

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Demo repo links: fix & check them all, update refcache #6124

merged 1 commit into from
Jan 30, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 30, 2025 •
edited
Loading

  • Contributes to [CI] External link checking improvements for 24H2-25H1 #5017
  • Removes temporary rule that had some external links into the demo repo igored
  • Updates links to services etc that were recently renamed.
  • Updates the refcache
  • I decided to fix the broken links in non-en pages, and to tag the links with a ?i18n-patch query parameter as an indicator for humans and tools that this is a link patch, but otherwise the rest of the page still matches it's default_lang_commit

@chalin chalin requested a review from a team as a code owner January 30, 2025 15:58
@opentelemetrybot opentelemetrybot requested review from a team and krol3 and removed request for a team January 30, 2025 15:58
julianocosta89
julianocosta89 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @chalin!

tiffany76
tiffany76 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin added this pull request to the merge queue Jan 30, 2025
Merged via the queue into open-telemetry:main with commit 66bbef7 Jan 30, 2025
17 checks passed
@chalin chalin deleted the chalin-im-demo-links-2025-01-30 branch January 30, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@tiffany76 tiffany76 tiffany76 approved these changes

@krol3 krol3 Awaiting requested review from krol3 krol3 was automatically assigned from open-telemetry/docs-es-approvers

Assignees
No one assigned
Labels
blog lang:es lang:ja lang:zh sig:demo
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @julianocosta89 @tiffany76