Heat pump active power was determined regardless its maximum power. N… #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow it is limited to the max active power and a warning given if done so.
Update to latest dev
…ow it is limited to the max active power and a warning given if done so.
khelfen
requested changes
Feb 28, 2025
edisgo/edisgo.py
Outdated
| @@ -55,6 +55,7 @@ | |||
| from edisgo.tools.geo import find_nearest_bus | |||
| from edisgo.tools.spatial_complexity_reduction import spatial_complexity_reduction | |||
| from edisgo.tools.tools import determine_grid_integration_voltage_level | |||
| from edisgo.io.db import engine as toep_engine | |||
| missing = set(heat_pump_names) - set(edisgo_obj.topology.loads_df.index) | ||
| if missing: | ||
| logger.warning( | ||
| f"The following heat pumps are are in the heat pump class but not yet " |
| @@ -28,3 +28,4 @@ Changes | |||
| * Move function to assign feeder to Topology class and add methods to the Grid class to get information on the feeders `#360 <https://github.com/openego/eDisGo/pull/360>`_ | |||
| * Added a storage operation strategy where the storage is charged when PV feed-in is higher than electricity demand of the household and discharged when electricity demand exceeds PV generation `#386 <https://github.com/openego/eDisGo/pull/386>`_ | |||
| * Added an estimation of the voltage deviation over a cable when selecting a suitable cable to connect a new component `#411 <https://github.com/openego/eDisGo/pull/411>`_ | |||
| * Added clipping of heat pump electrical power at its maximum value #428 <https://github.com/openego/eDisGo/pull/428> | |||
There was a problem hiding this comment.
this needs to be correctly formatted
| logger.warning( | ||
| f"The following heat pumps are are in the heat pump class but not yet " | ||
| f"integrated into the topology class. Therefore, their maximum capacity " | ||
| f"cannot be considered in the operating strategies. {missing=}" |
There was a problem hiding this comment.
Add a note similar to "For better results, please integrate these heat pumps into the topology before running this function.".
| ) | ||
| ts[in_topology] = ts_clipped[in_topology] | ||
|
|
||
| clipped = ts.eq(ts_prev).all()[lambda x: ~x].index |
There was a problem hiding this comment.
This should be more readable py using pandas.series.ne
| @@ -149,6 +149,7 @@ def _get_central_heat_pump_or_resistive_heaters(carrier): | |||
| <= edisgo_object.config["grid_connection"]["upper_limit_voltage_level_4"], | |||
| ) | |||
| df = pd.read_sql(query.statement, engine, index_col=None) | |||
| # Alternativ Code einfügen, falls Tabelle leer ist | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ow it is limited to the max active power and a warning given if done so.
Description
Heat pump active power was determined regardless its maximum power. Now it is limited to the max active power and a warning given if done so.
Fixes #383 (issue)
Type of change
Please delete options that are not relevant.
Checklist:
pre-commithooks