Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geoalchemy2 requirement from <0.7.0 to <0.18.0 #442

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 30, 2025

Updates the requirements on geoalchemy2 to permit the latest version.

Release notes

Sourced from geoalchemy2's releases.

0.17.0

What's Changed

Full Changelog: geoalchemy/geoalchemy2@0.16.0...0.17.0

Changelog

Sourced from geoalchemy2's changelog.

0.17.0

0.16.0

0.15.2

0.15.1

0.15.0

0.14.7

0.14.6

0.14.5

0.14.4

... (truncated)

Commits
  • eab5b71 Release/0.17.0 (#531)
  • c2d8f10 Perf: Enable cache, fix value casting for MySQL and MariaDB and add plugin fo...
  • c581698 CI: Disable SQLite for Pypy job (#528)
  • b51dc36 Release: 0.16.0 (#527)
  • 27712ca Test: Add test in test_functional.py for custom Geometry that uses WKT elemen...
  • b319a15 Add option to ensure all dialects are properly tested in CI (#526)
  • f93cf5a Improve MariaDB support (#524)
  • 4a5887a Release: 0.15.2 (#518)
  • f32331b Fix: Can handle negative coordinates with Spatialite (#517)
  • 8b7a2b1 [pre-commit.ci] pre-commit autoupdate (#514)
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 30, 2025
@dependabot dependabot bot requested a review from joda9 January 30, 2025 09:59
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 30, 2025

Dependabot can't evaluate your Python dependency files. Because of this, Dependabot cannot update this pull request.

@joda9 joda9 closed this Jan 30, 2025
@joda9 joda9 deleted the dependabot/pip/geoalchemy2-lt-0.18.0 branch January 30, 2025 17:10
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 30, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@joda9
Copy link
Collaborator

joda9 commented Feb 5, 2025

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 5, 2025

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

@joda9
Copy link
Collaborator

joda9 commented Feb 6, 2025

@dependabot reopen

@dependabot dependabot bot reopened this Feb 6, 2025
@dependabot dependabot bot restored the dependabot/pip/geoalchemy2-lt-0.18.0 branch February 6, 2025 16:38
@joda9
Copy link
Collaborator

joda9 commented Feb 6, 2025

@dependabot rebase

Updates the requirements on [geoalchemy2](https://github.com/geoalchemy/geoalchemy2) to permit the latest version.
- [Release notes](https://github.com/geoalchemy/geoalchemy2/releases)
- [Changelog](https://github.com/geoalchemy/geoalchemy2/blob/master/CHANGES.txt)
- [Commits](geoalchemy/geoalchemy2@0.1...0.17.0)

---
updated-dependencies:
- dependency-name: geoalchemy2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/geoalchemy2-lt-0.18.0 branch from b0e15e4 to a277721 Compare February 6, 2025 16:38
@joda9 joda9 requested a review from khelfen February 10, 2025 15:23
@joda9
Copy link
Collaborator

joda9 commented Feb 10, 2025

@khelfen Any idea why this was fixed to <0.7.0? If not, it seems reasonable to update.

@khelfen
Copy link
Collaborator

khelfen commented Feb 18, 2025

Hey :) I am not 100% sure why it is fixed. But looking into the tests shows that even if the restrictions are removed, it still only resolves the environment if the version is <0.7. See:

https://github.com/openego/eDisGo/actions/runs/13183559964/job/36955902663?pr=442#step:5:710

I think updating sqlalchemy and geoalchemy is a bigger issue. Currently, removing the restrictions just makes the install process longer, so I would not merge this until we address this in a more general way.

Copy link
Collaborator

@khelfen khelfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khelfen khelfen marked this pull request as draft February 18, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants