Reset FCP assignements of deleted VM #845
Draft
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bischoff
force-pushed
the
free-fcp-of-deleted-vm
branch
2 times, most recently
from
7412ab0 to
44e838b
Compare
Bischoff
force-pushed
the
free-fcp-of-deleted-vm
branch
from
44e838b to
21e9af1
Compare
mfriesenegger
force-pushed
the
free-fcp-of-deleted-vm
branch
from
21e9af1 to
bf6c209
Compare
Bischoff
force-pushed
the
free-fcp-of-deleted-vm
branch
from
bf6c209 to
327fe8c
Compare
Signed-off-by: Eric Bischoff <ebischoff@suse.com>
Bischoff
force-pushed
the
free-fcp-of-deleted-vm
branch
from
327fe8c to
dcf7056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT MERGE IMMEDIATELY
This PR was tested to work, but I'd like expert advice before merging it.
My code might be very naive, or even incorrect.
With current code when you:
AttachVolume()to that guestDetachVolume()then the disk stays counted as attached to the deleted instance.
If you recreate the instance, then
AttachVolume()will skip the dedication, because it considers that the disk is already dedicated to the instance, while it is not.This PR resets the FCP records in database for the deleted instance at time of deletion.