[bug fix] fix precompute ordering in max & min aggregator

[sandeshkr419]

Description

Fixes ordering change of pre-computation steps in Max/Min aggregator which was accidentally changed in #16733

Related Issues

For match-all cases, max/min aggregation without any parent/child aggregations can be precomputed faster than star-tree, so that's why it was prioritized over star-tree pre-computation. This ordering was modified accidentally in the above refactoring change, so making this change back.

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for ff08b28: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.99%. Comparing base (f6d6aa6) to head (ff08b28).
Report is 49 commits behind head on main.

Files with missing lines	Patch %	Lines
...rch/search/aggregations/metrics/MaxAggregator.java	25.00%	5 Missing and 1 partial ⚠️
...rch/search/aggregations/metrics/MinAggregator.java	28.57%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17505      +/-   ##
============================================
+ Coverage     72.47%   72.99%   +0.51%     
- Complexity    65705    66151     +446     
============================================
  Files          5307     5307              
  Lines        304774   304775       +1     
  Branches      44193    44193              
============================================
+ Hits         220898   222469    +1571     
+ Misses        65738    64474    -1264     
+ Partials      18138    17832     -306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

❌ Gradle check result for ff08b28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ff08b28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for ff08b28: SUCCESS

[andrross]

@msfroh @sandeshkr419 Should this be backported to 2.19 to go in the next patch release?

[msfroh]

I assumed that since star trees are not enabled by default, we don't need to backport fixes. @sandeshkr419, what do you think?

[sandeshkr419]

Star-tree are not enabled by default but users can turn on experimental features and in that scenario they will see performance degradation which will result in a negative user sentiment.

Plus, we mistakenly introduced this bug as part of code cleanup #16733 in 2.19 so I think we should back-port this to 2.19 patch release to keep things intact.