Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[segment replication] add SEGMENT_COUNTER_INCREMENT_STEP_SETTING and increase default step #17568

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[segment replication] add SEGMENT_COUNTER_INCREMENT_STEP_SETTING and increase default step #17568

wants to merge 5 commits into from

Conversation

guojialiang92
Copy link

@guojialiang92 guojialiang92 commented Mar 11, 2025 •
edited
Loading

Description

This PR solves the problem raised by issue 17566
To avoid segment number conflicts, adjust the default step to 100000.
In order to adjust flexibly, I have added dynamic configuration at the index level.

Related Issues

Resolves 17566

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added _No response_ enhancement Enhancement or improvement to existing feature or request labels Mar 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 36c979d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92 guojialiang92 force-pushed the dev/add_segment_counter_increment_step_setting branch from 36c979d to c3d39c5 Compare March 11, 2025 10:31
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c3d39c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f31109c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92
Copy link
Author

  • What went wrong:
    Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.

Building 2.19.1 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/bugfix/build/bwc/checkout-2.19/distribution/archives/linux-tar/build/distributions/opensearch-min-2.19.1-SNAPSHOT-linux-x64.tar.gz

It doesn't look like a code problem. Can anyone help take a look?

@andrross andrross added Indexing:Replication Issues and PRs related to core replication framework eg segrep and removed _No response_ labels Mar 13, 2025
@guojialiang92 guojialiang92 force-pushed the dev/add_segment_counter_increment_step_setting branch from f31109c to 931dc11 Compare March 14, 2025 10:11
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0b4018a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 14, 2025
Open
Closed
@guojialiang92
Merge remote-tracking branch 'origin/main' into dev/add_segment_count…
7676087 
…er_increment_step_setting

# Conflicts:
#	CHANGELOG.md
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7676087: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for c12b5c9: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (9b9abf7) to head (c12b5c9).

Files with missing lines Patch % Lines
.../main/java/org/opensearch/index/IndexSettings.java 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17568      +/-   ##
============================================
- Coverage     72.48%   72.38%   -0.10%     
+ Complexity    65835    65750      -85     
============================================
  Files          5316     5316              
  Lines        305281   305288       +7     
  Branches      44287    44287              
============================================
- Hits         221274   220977     -297     
- Misses        65851    66170     +319     
+ Partials      18156    18141      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr bugmakerrrrrr is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[segment replication] Increase the step size when replica promoting
2 participants
@guojialiang92 @andrross