-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Add Kinesis plugin support #17615
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for f267858: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for a09ead0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for a09ead0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/SequenceNumber.java
Show resolved
Hide resolved
plugins/ingestion-kinesis/licenses/aws-json-protocol-NOTICE.txt
Outdated
Show resolved
Hide resolved
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/KinesisMessage.java
Outdated
Show resolved
Hide resolved
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/KinesisShardConsumer.java
Outdated
Show resolved
Hide resolved
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/KinesisShardConsumer.java
Outdated
Show resolved
Hide resolved
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/KinesisShardConsumer.java
Outdated
Show resolved
Hide resolved
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/KinesisShardConsumer.java
Show resolved
Hide resolved
❌ Gradle check result for 3031cf8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 74e7329: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
❌ Gradle check result for d3735a8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yupeng Fu <[email protected]>
❌ Gradle check result for 83ab1f8: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good!
Just left a couple of minor comments and some "bookkeeping" comments to capture Slack discussion results in GitHub.
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/SequenceNumber.java
Show resolved
Hide resolved
plugins/ingestion-kinesis/src/main/java/org/opensearch/plugin/kinesis/SequenceNumber.java
Show resolved
Hide resolved
❌ Gradle check result for 83ab1f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yupeng Fu <[email protected]>
❌ Gradle check result for 15c571e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yupeng Fu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17615 +/- ##
============================================
- Coverage 72.53% 72.50% -0.04%
- Complexity 65826 65832 +6
============================================
Files 5311 5317 +6
Lines 305073 305211 +138
Branches 44243 44258 +15
============================================
- Hits 221293 221287 -6
- Misses 65688 65843 +155
+ Partials 18092 18081 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR adds support Kinesis as a plugin for pull-based ingestion. Because Kinesis has some differences from Kafka of modeling the stream, this requires some changes to the core stream poller. For example, Kinesis generates a sequence number for a new record, so it means it's not always possible to get the next sequence number when the offset is already at the head of the stream. Moreover, the sequence numbers between adjacent records are not consecutive, though they are still incremental. To accommodate Kinesis's behavior, we need to change the stream poller to track the last successful poll instead of getting the next pointer, which may not exist in Kinesis if the last offset is at the head of the stream.
Related Issues
Part of this META issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.