-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[segment replication] Add async publish checkpoint task #17619
base: main
Are you sure you want to change the base?
[segment replication] Add async publish checkpoint task #17619
Conversation
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17619 +/- ##
============================================
- Coverage 72.48% 72.41% -0.07%
+ Complexity 65835 65827 -8
============================================
Files 5316 5316
Lines 305281 305344 +63
Branches 44287 44302 +15
============================================
- Hits 221274 221113 -161
- Misses 65851 66130 +279
+ Partials 18156 18101 -55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
❕ Gradle check result for 3e146dc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
❕ Gradle check result for e067c6b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 2a272aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2a272aa
to
54945b2
Compare
❌ Gradle check result for 54945b2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
54945b2
to
23c1b87
Compare
❌ Gradle check result for 23c1b87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
23c1b87
to
4394239
Compare
❌ Gradle check result for 4394239: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
4394239
to
9b5a236
Compare
❕ Gradle check result for 9b5a236: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 546787d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
546787d
to
5e09825
Compare
❕ Gradle check result for 5e09825: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for af8670a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
af8670a
to
e21129f
Compare
❌ Gradle check result for e21129f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Added a test. In the current situation, if the primary shard publish checkpoint fails, it will cause the replica shard and the primary shard to fail to synchronize.
Added an asynchronous task. When the primary shard detects that the replica is behind for more than a certain time threshold, it triggers a publish checkpoint. And ensure that the above tests can be passed.
Related Issues
Resolves 17595
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.