Fix flaky test due to incorrect use of SSDV.nextOrd() #17626
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Maurya <[email protected]>
rishabhmaurya
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
reta
approved these changes
Mar 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17626 +/- ##
============================================
+ Coverage 72.46% 72.78% +0.31%
- Complexity 65757 66077 +320
============================================
Files 5311 5311
Lines 305001 305001
Branches 44230 44230
============================================
+ Hits 221022 221990 +968
+ Misses 65932 65187 -745
+ Partials 18047 17824 -223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reta
approved these changes
Mar 19, 2025
andrross
approved these changes
Mar 20, 2025
|
The copy-issue-labels workflow seems to be stuck? I'm going to close and re-open and see if that fixes things... |
|
❕ Gradle check result for 4399fef: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
expani
reviewed
Mar 20, 2025
server/src/test/java/org/opensearch/index/fielddata/ordinals/MultiOrdinalsTests.java
Show resolved
Hide resolved
expani
approved these changes
Mar 21, 2025
andrross
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lucene 10 makes it illegal to call
SortedSetDocValues#nextOrd()more than#docValueCount() times for the currently-positioned doc. This was causing flakiness inMultiOrdinalsTestsas encountered in PR #17446 with failure https://build.ci.opensearch.org/job/gradle-check/54686/testReport/junit/org.opensearch.index.fielddata.ordinals/MultiOrdinalsTests/testRandomValues/https://github.com/apache/lucene/blob/e7f9bc837e419672d9bfc829d01e643df667e9d4/lucene/core/src/java/org/apache/lucene/index/SortedSetDocValues.java#L36
We need to address this throughout the codebase thus created #17628
Related Issues
#17628
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.