Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calcite Engine]Support metadata field #3445

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

qianheng-aws
Copy link
Contributor

@qianheng-aws qianheng-aws commented Mar 19, 2025

Description

Support metadata field in Calcite. This PR also include changes:

  1. Fix the bug on v2 engine that cannot evaluate metadata field if it's not pushdown
  2. Add limitation of using metadata field on eval, alias and rename

Related Issues

Resolves #3333

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-aws qianheng-aws marked this pull request as ready for review March 20, 2025 05:24
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-aws
Copy link
Contributor Author

flakey failure:
CalcitePPLStringBuiltinFunctionPushdownIT > testSubstring

@LantaoJin LantaoJin added the calcite calcite migration releated label Mar 20, 2025
Signed-off-by: Heng Qian <qianheng@amazon.com>
@qianheng-aws qianheng-aws changed the base branch from feature/calcite-engine to main March 25, 2025 02:39
…calcite-engine-metadata

# Conflicts:
#	core/src/main/java/org/opensearch/sql/ast/expression/Alias.java
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/nonfallback/NonFallbackCalciteFieldsCommandIT.java
#	ppl/src/main/java/org/opensearch/sql/ppl/parser/AstStatementBuilder.java
Signed-off-by: Heng Qian <qianheng@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calcite calcite migration releated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support metadata fields in fields command with Calcite
2 participants