Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: use release 'url' in ApplianceConfig #1738

Conversation

danielerez
Copy link
Contributor

@danielerez danielerez commented Mar 18, 2025

The appliance now supports using a release image URL: openshift/appliance#352
Hence, we can now use a nightly/ci release url in the ApplianceConfig template.
Also no need for 'imageRegistry' as the appliance now builds the registry internally: openshift/appliance#349

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@danielerez
Copy link
Contributor Author

/test ?

Copy link

openshift-ci bot commented Mar 18, 2025

@danielerez: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danielerez danielerez force-pushed the applianceconfig_releaseurl branch from 5e3b458 to 86c780e Compare March 18, 2025 10:27
@danielerez danielerez marked this pull request as ready for review March 18, 2025 10:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@andfasano
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 18, 2025
@danielerez
Copy link
Contributor Author

/test ?

Copy link

openshift-ci bot commented Mar 18, 2025

@danielerez: No presubmit jobs available for openshift-metal3/dev-scripts@master

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danielerez
Copy link
Contributor Author

/test pull-ci-openshift-appliance-master-e2e-sno-dualstack-dhcp

Copy link

openshift-ci bot commented Mar 18, 2025

@danielerez: No presubmit jobs available for openshift-metal3/dev-scripts@master

In response to this:

/test pull-ci-openshift-appliance-master-e2e-sno-dualstack-dhcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andfasano
Copy link
Member

/test

Copy link

openshift-ci bot commented Mar 18, 2025

@andfasano: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4
/test e2e-metal-ipi-bm
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-serial-ipv4
/test images

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4
/test e2e-agent-5control-ipv4
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6
/test e2e-metal-ipi-bm-bond
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-v6
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-upgrade
/test e2e-metal-ipi-upgrade-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-4control-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-5control-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-ha-dualstack
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6
pull-ci-openshift-metal3-dev-scripts-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danielerez
Copy link
Contributor Author

/test

Copy link

openshift-ci bot commented Mar 18, 2025

@danielerez: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4
/test e2e-metal-ipi-bm
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-serial-ipv4
/test images

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4
/test e2e-agent-5control-ipv4
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6
/test e2e-metal-ipi-bm-bond
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-v6
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-upgrade
/test e2e-metal-ipi-upgrade-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-4control-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-5control-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-ha-dualstack
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6
pull-ci-openshift-metal3-dev-scripts-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andfasano
Copy link
Member

/test e2e-agent-compact-ipv4

@danielerez
Copy link
Contributor Author

/test pull-ci-openshift-appliance-master-e2e-sno-dualstack-dhcp

Copy link

openshift-ci bot commented Mar 18, 2025

@danielerez: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4
/test e2e-metal-ipi-bm
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-serial-ipv4
/test images

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4
/test e2e-agent-5control-ipv4
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6
/test e2e-metal-ipi-bm-bond
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-v6
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-upgrade
/test e2e-metal-ipi-upgrade-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-4control-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-5control-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-ha-dualstack
pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6
pull-ci-openshift-metal3-dev-scripts-master-images

In response to this:

/test pull-ci-openshift-appliance-master-e2e-sno-dualstack-dhcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Mar 18, 2025

@andfasano: No presubmit jobs available for openshift-metal3/dev-scripts@master

In response to this:

/test e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danielerez
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2025
@andfasano
Copy link
Member

/approve

Copy link

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
The appliance now supports using a release image URL:
openshift/appliance#352
Hence, we can now use a nightly release url in
the ApplianceConfig template.
Also no need for 'imageRegistry' as the appliance
now builds the registry internally:
openshift/appliance#349
@danielerez danielerez force-pushed the applianceconfig_releaseurl branch from 86c780e to 8f5b988 Compare March 25, 2025 15:35
@danielerez
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2025
@pawanpinjarkar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@pawanpinjarkar
Copy link
Contributor

/override ci/prow/e2e-agent-compact-ipv4

Copy link

openshift-ci bot commented Mar 25, 2025

@pawanpinjarkar: pawanpinjarkar unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawanpinjarkar
Copy link
Contributor

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 977a121 into openshift-metal3:master Mar 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants