-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent: use release 'url' in ApplianceConfig #1738
agent: use release 'url' in ApplianceConfig #1738
Conversation
/test ? |
@danielerez: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5e3b458
to
86c780e
Compare
/ok-to-test |
/test ? |
@danielerez: No presubmit jobs available for openshift-metal3/dev-scripts@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-ci-openshift-appliance-master-e2e-sno-dualstack-dhcp |
@danielerez: No presubmit jobs available for openshift-metal3/dev-scripts@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test |
@andfasano: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test |
@danielerez: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-agent-compact-ipv4 |
/test pull-ci-openshift-appliance-master-e2e-sno-dualstack-dhcp |
@danielerez: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andfasano: No presubmit jobs available for openshift-metal3/dev-scripts@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The appliance now supports using a release image URL: openshift/appliance#352 Hence, we can now use a nightly release url in the ApplianceConfig template. Also no need for 'imageRegistry' as the appliance now builds the registry internally: openshift/appliance#349
86c780e
to
8f5b988
Compare
/unhold |
/lgtm |
/override ci/prow/e2e-agent-compact-ipv4 |
@pawanpinjarkar: pawanpinjarkar unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
977a121
into
openshift-metal3:master
The appliance now supports using a release image URL: openshift/appliance#352
Hence, we can now use a nightly/ci release url in the ApplianceConfig template.
Also no need for 'imageRegistry' as the appliance now builds the registry internally: openshift/appliance#349