OCPBUGS-52258: pkg/cvo/updatepayload: Context around ValidateDirectory calls

[wking]

These usually either succeed or give os.IsNotExist, but in some cases can return errors like:

Unable to download and prepare the update: stat /etc/cvo/updatepayloads/7WNaprXJNWTsPAepCHJ00Q/release-manifests/release-metadata: permission denied.

To make it easier to debug those situations, this commit adds context to errors near ValidateDirectory calls, so it's more clear that the issue is the CVO's attempts to read /etc/cvo/... failing, and not an error with the version-... Pod, registry access, etc.

Also while I'm in this space, I've replaced the old errors.Wrap in ImageForShortName with fmt.Errorf(...%w, ...), now that the Go standard libraries support error-wrapping like that. One fewer 3rd-party dependency call-site.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-52258, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

These usually either succeed or give os.IsNotExist, but in some cases can return errors like:

Unable to download and prepare the update: stat /etc/cvo/updatepayloads/7WNaprXJNWTsPAepCHJ00Q/release-manifests/release-metadata: permission denied.

To make it easier to debug those situations, this commit adds context to errors near ValidateDirectory calls, so it's more clear that the issue is the CVO's attempts to read /etc/cvo/... failing, and not an error with the version-... Pod, registry access, etc.

Also while I'm in this space, I've replaced the old errors.Wrap in ImageForShortName with fmt.Errorf(...%w, ...), now that the Go standard libraries support error-wrapping like that. One fewer 3rd-party dependency call-site.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wking]

/Jira refresh

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-52258, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

In response to this:

/Jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jiajliu]

cc @JianLi-RH

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JianLi-RH]

/label qe-approved

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-52258, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

These usually either succeed or give os.IsNotExist, but in some cases can return errors like:

Unable to download and prepare the update: stat /etc/cvo/updatepayloads/7WNaprXJNWTsPAepCHJ00Q/release-manifests/release-metadata: permission denied.

To make it easier to debug those situations, this commit adds context to errors near ValidateDirectory calls, so it's more clear that the issue is the CVO's attempts to read /etc/cvo/... failing, and not an error with the version-... Pod, registry access, etc.

Also while I'm in this space, I've replaced the old errors.Wrap in ImageForShortName with fmt.Errorf(...%w, ...), now that the Go standard libraries support error-wrapping like that. One fewer 3rd-party dependency call-site.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ff3778c and 2 for PR HEAD b4119c2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ff3778c and 2 for PR HEAD b4119c2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6ca3650 and 1 for PR HEAD b4119c2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6ca3650 and 2 for PR HEAD b4119c2 in total

[openshift-ci]

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@wking: Jira Issue OCPBUGS-52258: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#1166

Jira Issue OCPBUGS-52258 has been moved to the MODIFIED state.

In response to this:

These usually either succeed or give os.IsNotExist, but in some cases can return errors like:

Unable to download and prepare the update: stat /etc/cvo/updatepayloads/7WNaprXJNWTsPAepCHJ00Q/release-manifests/release-metadata: permission denied.

To make it easier to debug those situations, this commit adds context to errors near ValidateDirectory calls, so it's more clear that the issue is the CVO's attempts to read /etc/cvo/... failing, and not an error with the version-... Pod, registry access, etc.

Also while I'm in this space, I've replaced the old errors.Wrap in ImageForShortName with fmt.Errorf(...%w, ...), now that the Go standard libraries support error-wrapping like that. One fewer 3rd-party dependency call-site.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.19.0-202503080439.p0.g431ea6c.assembly.stream.el9.
All builds following this will include this PR.