Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1403: Move the CVO CLI Application to a Separate Folder #1169

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

DavidHurta
Copy link
Contributor

So that we can have multiple CLI applications in the cmd folder.

For example, cmd/cluster-version-operator/, cmd/cvo-tests/, cmd/cluster-version-operator-v2/.

Being done to tidy the folder for #1168.

So that we can have multiple CLI applications in the `cmd` folder.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2025

@DavidHurta: This pull request references OTA-1403 which is a valid jira issue.

In response to this:

So that we can have multiple CLI applications in the cmd folder.

For example, cmd/cluster-version-operator/, cmd/cvo-tests/, cmd/cluster-version-operator-v2/.

Being done to tidy the folder for #1168.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta
Copy link
Contributor Author

I do not have a strong opinion regarding naming. Feel free to propose a different alternative. Maybe cmd/cvo is enough?

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 13, 2025

I do not have a strong opinion regarding naming. Feel free to propose a different alternative. Maybe cmd/cvo is enough?

And then we can call the new tests extension cvo-tests instead of cluster-version-operator-tests, openshift-tests-extension, tests-extension, or tests.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DavidHurta,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidHurta
Copy link
Contributor Author

\label no-qe

The change is minimal. The only instance of referencing the files is the hack/build-go.sh script, which was updated. Any issues would result in compilation/build errors.

@DavidHurta
Copy link
Contributor Author

/retest-required

@DavidHurta
Copy link
Contributor Author

/label no-qe

Typo in #1169 (comment).

@openshift-ci openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label Mar 13, 2025
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@DavidHurta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 7a79afb link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4ec8c48 into openshift:main Mar 14, 2025
14 of 15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.19.0-202503140309.p0.g4ec8c48.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants