Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTA-1351: Migrate base of image of e2e test to ubi9 #62510

Merged
merged 1 commit into from
Mar 11, 2025
Merged

OTA-1351: Migrate base of image of e2e test to ubi9 #62510

merged 1 commit into from
Mar 11, 2025

Conversation

hongkailiu
Copy link
Member

/hold

Need openshift/cincinnati#1000 to go first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/hold

Need openshift/cincinnati#1000 to go first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from petr-muller and wking March 6, 2025 21:20
@openshift-ci-robot
Copy link
Contributor

@hongkailiu, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 225e612343db314e33a118a735aa3a74cfbda765]' failed with out:  and error exec: Stdout already set
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

hongkailiu added a commit to hongkailiu/cincinnati that referenced this pull request Mar 6, 2025
@hongkailiu
Revert the changes on ubi8 and
e22688c 
```console
$ mkdir dist/Dockerfile.e2e-ubi9/
$ cp dist/Dockerfile.e2e-ubi8/Dockerfile dist/Dockerfile.e2e-ubi9/Dockerfile
$ git checkout head~1 -- dist/Dockerfile.e2e-ubi8/
```

TODO: Remove `dist/Dockerfile.e2e-ubi8/Dockerfile` after [1] gets in.

[1]. openshift/release#62510
hongkailiu added a commit to hongkailiu/cincinnati that referenced this pull request Mar 6, 2025
@hongkailiu
Revert the changes on ubi8 and mkdir for ubi9
5cc8af9 
```console
$ mkdir dist/Dockerfile.e2e-ubi9/
$ cp dist/Dockerfile.e2e-ubi8/Dockerfile dist/Dockerfile.e2e-ubi9/Dockerfile
$ git checkout head~1 -- dist/Dockerfile.e2e-ubi8/
```

TODO: Remove `dist/Dockerfile.e2e-ubi8/Dockerfile` after [1] gets in.

[1]. openshift/release#62510
hongkailiu added a commit to hongkailiu/cincinnati that referenced this pull request Mar 6, 2025
@hongkailiu
Revert the changes on ubi8 and mkdir for ubi9
644a775 
```console
$ mkdir dist/Dockerfile.e2e-ubi9/
$ cp dist/Dockerfile.e2e-ubi8/Dockerfile dist/Dockerfile.e2e-ubi9/Dockerfile
$ git checkout head~2 -- dist/Dockerfile.e2e-ubi8/
```

TODO: Remove `dist/Dockerfile.e2e-ubi8/Dockerfile` after [1] gets in.

[1]. openshift/release#62510
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hongkailiu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cincinnati-master-cargo-test openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-cargo-test openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-e2e openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-images openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-rustfmt-1.64.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-rustfmt-1.70.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-yaml-lint openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-e2e openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-images openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-rustfmt-1.64.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-rustfmt-1.70.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-yaml-lint openshift/cincinnati presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

hongkailiu added a commit to hongkailiu/cincinnati that referenced this pull request Mar 10, 2025
@hongkailiu
Rename the e2e dockerfile folder
0293214 
The e2e job is broken until [1] gets in.

[1]. openshift/release#62510
@hongkailiu hongkailiu mentioned this pull request Mar 10, 2025
Merged
hongkailiu added a commit to hongkailiu/cincinnati that referenced this pull request Mar 10, 2025
@hongkailiu
Revert the changes on ubi8 and mkdir for ubi
2ab750f 
The new folder name is not associated with the ubi version

```console
$ mkdir dist/Dockerfile.e2e-ubi/
$ cp dist/Dockerfile.e2e-ubi8/Dockerfile dist/Dockerfile.e2e-ubi/Dockerfile
$ git checkout head~2 -- dist/Dockerfile.e2e-ubi8/
```

TODO: Remove `dist/Dockerfile.e2e-ubi8/Dockerfile` after [1] gets in.

[1]. openshift/release#62510
@hongkailiu
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cincinnati-master-images

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu hongkailiu mentioned this pull request Mar 10, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@hongkailiu, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 1a568bb4f801d95cb0050adc49841348bbe53933]' failed with out:  and error exec: Stdout already set

If the problem persists, please contact Test Platform.

@hongkailiu
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cincinnati-master-e2e

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cincinnati-master-customrust-e2e

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cincinnati-master-customrust-e2e

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

PratikMahajan
PratikMahajan approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@PratikMahajan PratikMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2025
@hongkailiu
Copy link
Member Author

/hold cancel
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 11, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller, PratikMahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/test check-gh-automation

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 72cc0e2 into openshift:master Mar 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@PratikMahajan PratikMahajan PratikMahajan approved these changes

@wking wking Awaiting requested review from wking

Assignees

@petr-muller petr-muller

@PratikMahajan PratikMahajan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongkailiu @openshift-ci-robot @petr-muller @PratikMahajan