Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: cincinnati e2e: replace images from app.ci with tags #62724

Merged
merged 1 commit into from
Mar 13, 2025
Merged

NO-JIRA: cincinnati e2e: replace images from app.ci with tags #62724

merged 1 commit into from
Mar 13, 2025

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Mar 12, 2025 •
edited
Loading

With #62541 merged and the images are now available at QCI:

$ podman pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_ubi9 --authfile /tmp/t.c --platform linux/amd64
Trying to pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_ubi9...
Getting image source signatures
Copying blob sha256:...

$ podman pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_e2e-test-ubi9 --authfile /tmp/t.c --platform linux/amd64
Trying to pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_e2e-test-ubi9...
Getting image source signatures
Copying blob sha256:...

Requiring openshift/cincinnati#1006

/hold

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

Requiring openshift/cincinnati#1006

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

With #62541 merged and the images are now available at QCI:

$ podman pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_ubi9 --authfile /tmp/t.c --platform linux/amd64
Trying to pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_ubi9...
Getting image source signatures
Copying blob sha256:...

$ podman pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_e2e-test-ubi9 --authfile /tmp/t.c --platform linux/amd64
Trying to pull quay-proxy.ci.openshift.org/openshift/ci:cincinnati-ci-public_rust_e2e-test-ubi9...
Getting image source signatures
Copying blob sha256:...

Requiring openshift/cincinnati#1006

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cincinnati-master-e2e
/pj-rehearse pull-ci-openshift-cincinnati-master-images

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hongkailiu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cincinnati-master-cargo-test openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-cargo-test openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-e2e openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-images openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-rustfmt-1.64.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-rustfmt-1.70.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-customrust-yaml-lint openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-e2e openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-images openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-rustfmt-1.64.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-rustfmt-1.70.0 openshift/cincinnati presubmit Ci-operator config changed
pull-ci-openshift-cincinnati-master-yaml-lint openshift/cincinnati presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cincinnati-master-images

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

The rehearsal looks good to me.

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/62724/rehearse-62724-pull-ci-openshift-cincinnati-master-e2e/1900219631939883008/artifacts/build-logs/e2e-test-amd64.log | rg 'FROM '
2025-03-13T16:37:52.147226886Z [1/2] STEP 1/6: FROM image-registry.openshift-image-registry.svc:5000/ci-op-6w0k0tnk/pipeline@sha256:367cce58beec5744e497245336be679b9e27546976b5de9a62ca91ac48d2570e AS rust_builder
2025-03-13T16:41:03.001458668Z [2/2] STEP 1/20: FROM image-registry.openshift-image-registry.svc:5000/ci-op-6w0k0tnk/pipeline@sha256:e945e3586e23861ff7c16e44ce8f11684e33bb36fc0f4b01e8fdf879d65341f5

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/62724/rehearse-62724-pull-ci-openshift-cincinnati-master-e2e/1900219631939883008/artifacts/build-resources/imagestreams.json | yq -y '.items[]|select(.metadata.name=="pipeline")|.status.tags[]|select(.tag=="rust" or .tag=="e2e")'
tag: e2e
items:
  - created: '2025-03-13T16:17:35Z'
    dockerImageReference: quay-proxy.ci.openshift.org/openshift/ci@sha256:e945e3586e23861ff7c16e44ce8f11684e33bb36fc0f4b01e8fdf879d65341f5
    image: sha256:e945e3586e23861ff7c16e44ce8f11684e33bb36fc0f4b01e8fdf879d65341f5
    generation: 6
---
tag: rust
items:
  - created: '2025-03-13T16:17:35Z'
    dockerImageReference: quay-proxy.ci.openshift.org/openshift/ci@sha256:367cce58beec5744e497245336be679b9e27546976b5de9a62ca91ac48d2570e
    image: sha256:367cce58beec5744e497245336be679b9e27546976b5de9a62ca91ac48d2570e
    generation: 6

@hongkailiu
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 13, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ddbe54d into openshift:master Mar 13, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@wking wking Awaiting requested review from wking

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongkailiu @openshift-ci-robot @petr-muller