CORE-783 Help menu #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivey
reviewed
Mar 24, 2025
src/components/HelpMenu.tsx
Outdated
| }; | ||
|
|
||
| const IframeWrapper = styled.div` | ||
| background-color: #F5F5F5; |
There was a problem hiding this comment.
I think this is neutralBright in the color palette
| display: none; | ||
| #ladle-root { | ||
| position: absolute; | ||
| right: 0; |
There was a problem hiding this comment.
Yeah this is probably better than the pseudo-preview mode
src/components/HelpMenu.tsx
Outdated
| button { | ||
| height: 3rem; | ||
| background-color: white; | ||
| border: 1px solid #D5D5D5; |
There was a problem hiding this comment.
might want to use the color palette here too
|
@jivey I think the back button being weird is really a side-effect of the shenanigans I had to do specifically in ladle to have the ladle sidebar still work in body portal mode. Normally the contact us form should occupy the whole screen, but here it's getting restricted to the side, so the button looks weird. |
|
It seems that instead of pushing ladle-root to the side I can set |
jivey
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-783