Feat/pci kubernetes plan tapc 2244 #16119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: DEPLOYMENT_TAPC-2768 Signed-off-by: Pierre-Philippe <[email protected]>
ref: DEPLOYMENT_TAPC-2768 Signed-off-by: Pierre-Philippe <[email protected]>
ref: DEPLOYMENT_TAPC-2768 Signed-off-by: Pierre-Philippe <[email protected]>
ref: DEPLOYMENT_TAPC-2768 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ppprevost
requested review from
lionel95200x,
selm3n and
Eric-ciccotti
and removed request for
a team
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
fredericvilcot
requested changes
Mar 21, 2025
packages/manager/apps/pci-kubernetes/src/components/radio-tile/RadioTile.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/components/region-selector/KubeDeploymentTile.tsx
Outdated
Show resolved
Hide resolved
.../manager/apps/pci-kubernetes/src/components/region-selector/KubeRegionSelector.component.tsx
Show resolved
Hide resolved
.../manager/apps/pci-kubernetes/src/components/region-selector/KubeRegionSelector.component.tsx
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/hooks/use3azPlanAvaible.ts
Outdated
Show resolved
Hide resolved
Comment on lines
68
to
70
| const { t } = (useTranslation(['add', 'stepper']) as unknown) as { | ||
| t: TFunction<'add'>; | ||
| }; |
There was a problem hiding this comment.
Why this type cast?
There was a problem hiding this comment.
it seems not to be used right now, i change it :)
added 3 commits
March 21, 2025 11:29
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
added 2 commits
March 21, 2025 11:56
ref: TAPC-2244 Signed-off-by: Pierre-Philippe <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #...
TAPC-2244
TAPC-2767
Additional Information
Please note that I have mocked some functions because the 3AZ deployment mode is not yet available. The 2199 branch will be merged into master only when I receive backend data that supports 3AZ.