feat(vrack): add resource ovh_vrack_dedicated_cloud_datacenter #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaweb
force-pushed
the
add-vrack-dedicatedCloudDatacenter
branch
2 times, most recently
from
0e8944e to
5e4a66d
Compare
dlaweb
force-pushed
the
add-vrack-dedicatedCloudDatacenter
branch
from
5e4a66d to
bc10dad
Compare
amstuta
requested changes
Mar 21, 2025
| resource "ovh_vrack_dedicated_cloud_datacenter" "vrack-dedicatedCloudDatacenter" { | ||
| service_name = "<vRack service name>" | ||
| datacenter = "<Dedicated Cloud Datacenter service name>" | ||
| target_service_name = "<vRack target service name>" |
There was a problem hiding this comment.
Suggested change
| target_service_name = "<vRack target service name>" | |
| target_service_name = "<vRack target service name>" |
| Move a Dedicated Cloud Datacenter to a vrack. | ||
|
|
||
| ## Example Usage | ||
|
|
There was a problem hiding this comment.
you should mention before this example that the resource cannot be created and needs to be imported first. I know the information is already in the ## Import section, but a paragraph starting with ~> would be more visible.
| return nil | ||
| } | ||
|
|
||
| func TestAccVrackDedicatedCloudDatacenter_basic(t *testing.T) { |
There was a problem hiding this comment.
not sure this test works ? I think ImportState and other import-related configs are missing from your test step since resource cannot be created
| return | ||
| } | ||
|
|
||
| resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("service_name"), splits[0])...) |
| Description: "Your dedicatedCloud name", | ||
| MarkdownDescription: "Your dedicatedCloud name", | ||
| }, | ||
| "vrack": schema.StringAttribute{ |
There was a problem hiding this comment.
I think this field is useless now, it can be removed
| }, | ||
| "target_service_name": schema.StringAttribute{ | ||
| CustomType: ovhtypes.TfStringType{}, | ||
| Optional: true, |
There was a problem hiding this comment.
Suggested change
| Optional: true, | |
| Computed: true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add resource ovh_vrack_dedicated_cloud_datacenter
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccVrackDedicatedCloudDatacenter_basic"Test Configuration:
terraform version: Terraform vx.y.zChecklist:
go mod vendorif I added or modifygo.modfile