fix: update code to pass latest test suite #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalluck
commented
Feb 27, 2025
dwalluck
commented
Feb 27, 2025
This was referenced Mar 10, 2025
dwalluck
force-pushed
the
update-test-suite
branch
from
1312191 to
0a8f35e
Compare
jeremylong
reviewed
Mar 13, 2025
dwalluck
force-pushed
the
update-test-suite
branch
from
0a8f35e to
56b81a4
Compare
|
@dwalluck mind fixing the merge conflicts? |
dwalluck
force-pushed
the
update-test-suite
branch
from
56b81a4 to
61098f2
Compare
|
Needs #205 first. |
|
There is one more merge conflict that needs to be resolved. |
|
This really needs #176 first, as this pull request basically contains a version of that pull request. I am not sure why I submitted the one required first after this one. |
dwalluck
force-pushed
the
update-test-suite
branch
from
61098f2 to
63815d1
Compare
dwalluck
changed the title
dwalluck
changed the title
dwalluck
force-pushed
the
update-test-suite
branch
from
63815d1 to
aff90d8
Compare
|
Now that Spotless is there, there will be some conflicts. This should help: |
dwalluck
force-pushed
the
update-test-suite
branch
from
aff90d8 to
86ea212
Compare
dwalluck
commented
Mar 19, 2025
Comment on lines
63
to
93
| @Test | ||
| void validPercentEncoding() throws MalformedPackageURLException { | ||
| PackageURL purl = new PackageURL("maven", "com.google.summit", "summit-ast", "2.2.0\n", null, null); | ||
| assertEquals("pkg:maven/com.google.summit/[email protected]%0A", purl.toString()); | ||
| PackageURL purl2 = | ||
| new PackageURL("pkg:nuget/%D0%9Cicros%D0%BEft.%D0%95ntit%D1%83Fram%D0%B5work%D0%A1%D0%BEr%D0%B5"); | ||
| assertEquals("Мicrosоft.ЕntitуFramеworkСоrе", purl2.getName()); | ||
| assertEquals( | ||
| "pkg:nuget/%D0%9Cicros%D0%BEft.%D0%95ntit%D1%83Fram%D0%B5work%D0%A1%D0%BEr%D0%B5", purl2.toString()); | ||
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| @Test | ||
| void invalidPercentEncoding() throws MalformedPackageURLException { | ||
| assertThrowsExactly( | ||
| MalformedPackageURLException.class, | ||
| () -> new PackageURL("pkg:maven/com.google.summit/[email protected]%")); | ||
| assertThrowsExactly( | ||
| MalformedPackageURLException.class, | ||
| () -> new PackageURL("pkg:maven/com.google.summit/[email protected]%0")); | ||
| PackageURL purl = new PackageURL("pkg:maven/com.google.summit/[email protected]"); | ||
| Throwable t1 = assertThrowsExactly(ValidationException.class, () -> purl.uriDecode("%")); | ||
| assertEquals("Incomplete percent encoding at offset 0 with value '%'", t1.getMessage()); | ||
| Throwable t2 = assertThrowsExactly(ValidationException.class, () -> purl.uriDecode("a%0")); | ||
| assertEquals("Incomplete percent encoding at offset 1 with value '%0'", t2.getMessage()); | ||
| Throwable t3 = assertThrowsExactly(ValidationException.class, () -> purl.uriDecode("aaaa%%0A")); | ||
| assertEquals("Invalid percent encoding char 1 at offset 5 with value '%'", t3.getMessage()); | ||
| Throwable t4 = assertThrowsExactly(ValidationException.class, () -> purl.uriDecode("%0G")); | ||
| assertEquals("Invalid percent encoding char 2 at offset 2 with value 'G'", t4.getMessage()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Unintentional merge issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.