fix: add missing @deprecated and @since to javadoc
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalluck
force-pushed
the
deprecated-and-since
branch
from
6bf1488 to
d5ae5d6
Compare
dwalluck
commented
Mar 17, 2025
dwalluck
force-pushed
the
deprecated-and-since
branch
3 times, most recently
from
09795a0 to
66887d9
Compare
ppkarwasz
suggested changes
Mar 18, 2025
dwalluck
force-pushed
the
deprecated-and-since
branch
2 times, most recently
from
f5f06c9 to
9c4cf57
Compare
dwalluck
changed the title
@deprecated and @since to javadoc@deprecated and @since to javadoc
dwalluck
force-pushed
the
deprecated-and-since
branch
3 times, most recently
from
09d7a99 to
0d2ba8f
Compare
|
@ppkarwasz you good with this one now? |
ppkarwasz
approved these changes
Mar 19, 2025
|
Now that Spotless is there, there will be some conflicts. This should help: |
dwalluck
force-pushed
the
deprecated-and-since
branch
from
e38f770 to
1d4ad9b
Compare
Add some missing javadoc. Fix some method visibility issues and remove use of deprecated methods from code.
dwalluck
force-pushed
the
deprecated-and-since
branch
from
1d4ad9b to
72aea80
Compare
|
Could you avoid forced pushes to PRs and use |
ppkarwasz
approved these changes
Mar 19, 2025
I understand., I tended to be worried about a bunch of messages in the history for projects that don't squash before they merge. |
ppkarwasz
approved these changes
Mar 21, 2025
jeremylong
previously approved these changes
Mar 21, 2025
|
@dwalluck mind fixing the merge conflicts? thanks! |
jeremylong
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing javadoc.
Fix some method visibility issues and remove use of deprecated methods from code.