Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires a deposit for setting session keys #1625

Open
xlc opened this issue Sep 19, 2023 · 4 comments
Open

Requires a deposit for setting session keys #1625

xlc opened this issue Sep 19, 2023 · 4 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@xlc
Copy link
Contributor

xlc commented Sep 19, 2023

Previous issue paritytech/substrate#9267
@shawntabrizi
Copy link
Member

@bkchr i believe this should be marked as easy / medium.

Might need a storage migration, but this should be a good issue for students out of the academy.

@bkchr bkchr added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Mar 11, 2024
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Statemine primitives (#1625)
3e00c5c 
* Statemine primitives

* ref issue in TODO

* fix TODO
@bkchr bkchr mentioned this issue May 17, 2024
Closed
@bkchr bkchr added the C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. label Feb 27, 2025
@Krayt78
Copy link
Contributor

Krayt78 commented Mar 17, 2025

Hi Guys, i could take care of that if you want.
What would need to be done ? Just staking some tokens on set_keys and freeing them once the the keys get purged ?
And create a migration script

@bkchr
Copy link
Member

bkchr commented Mar 17, 2025

What would need to be done ? Just staking some tokens on set_keys and freeing them once the the keys get purged ?

Yes exactly, reserve some funds.

And create a migration script

Not needed.

@Krayt78
Copy link
Contributor

Krayt78 commented Mar 18, 2025 •
edited
Loading

Here is my PR for this #7953
I added the reserve logic, added events on reserve/unreserved (is this too much?), some unit tests to make sure that it functions as intended and refactored the set_keys to remove redundant storage reads.

The only thing i am not sure about is how to properly mock the pallet_balances and the ReservableCurrency.
Let me know if i need to change anything !

@Krayt78 Krayt78 mentioned this issue Mar 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xlc @shawntabrizi @bkchr @Krayt78