Add deposit for setting session keys #7953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pallet. Update KeyDeposit type to use BalanceOf. Add tests for setting and purging keys to verify fund reservation and unreservation.
…undant storage reads and improve efficiency in the session pallet.
xlc
reviewed
Mar 18, 2025
i wil l change to use named reserve instead then, but from what i can see i still need to use ReservableCurrency for the can_reserve function since NamedReservableCurrency doesnt seem to implement it |
bkchr
reviewed
Mar 18, 2025
substrate/frame/session/src/lib.rs
Outdated
Comment on lines
446
to
449
| type Currency: NamedReservableCurrency<Self::AccountId>; | ||
|
|
||
| /// The reserve identifier type. | ||
| type ReserveIdentifier: Get<<Self::Currency as NamedReservableCurrency<Self::AccountId>>::ReserveIdentifier> + TypeInfo + 'static; |
There was a problem hiding this comment.
i have just pushed a fix to replace Reserve by Hold instead
…functionality for key management. Update related types and events to reflect changes from reservation to holding of funds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is for #1625
Implement reserved balance tracking for test accounts in the session pallet.
Update KeyDeposit type to use BalanceOf. Add tests for setting and purging keys to verify fund reservation and unreservation.
Update inner_set_keys to accept old keys as an argument to reduce redundant storage reads and improve efficiency in the session pallet.