Update pallet election provider multi phase to support Block Number Provider #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharjeezy
changed the title
…n_provider_multi_phase_block_number_provider
muharem
reviewed
Feb 11, 2025
| @@ -298,6 +299,9 @@ pub type SolutionAccuracyOf<T> = | |||
| /// The fallback election type. | |||
| pub type FallbackErrorOf<T> = <<T as crate::Config>::Fallback as ElectionProviderBase>::Error; | |||
|
|
|||
| pub type BlockNumberFor<T> = | |||
There was a problem hiding this comment.
please a doc for public item
Comment on lines
718
to
719
| /// Provider for the block number. Normally this is the `frame_system` pallet. | ||
| type BlockNumberProvider: BlockNumberProvider; |
There was a problem hiding this comment.
what is normally? I commented your the same doc from you #6297 (comment)
There was a problem hiding this comment.
i have doc properly now
…n_provider_multi_phase_block_number_provider # Conflicts: # substrate/frame/election-provider-multi-phase/src/lib.rs # substrate/frame/election-provider-multi-phase/src/unsigned.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces BlockNumberProvider config for the election provider multi phase pallet.
closes part of #6297
Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW